Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.html

Issue 2179223004: MD Settings: Internet: Clean up network and proxy sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_609156_internet_cleanup_3
Patch Set: Add MAX_NAMESERVERS Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_shared_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/internet_page/internet_detail_page.html
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.html b/chrome/browser/resources/settings/internet_page/internet_detail_page.html
index e4f8667b29cba2ae1c85830cdb858b73f5239362..850e1252b824a74475c46b1e9456554ccfa38d9f 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.html
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.html
@@ -10,7 +10,7 @@
<link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.html">
<link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network_behavior.html">
<link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network_indicator.html">
-<link rel="import" href="/settings_shared_css.html">
+<link rel="import" href="internet_shared_css.html">
<link rel="import" href="network_apnlist.html">
<link rel="import" href="network_ip_config.html">
<link rel="import" href="network_nameservers.html">
@@ -20,7 +20,7 @@
<dom-module id="settings-internet-detail-page">
<template>
- <style include="settings-shared">
+ <style include="internet-shared">
iron-collapse {
margin: 10px;
}
@@ -35,17 +35,8 @@
-webkit-margin-start: 10px;
}
- div.indented {
- -webkit-margin-start: 20px;
- }
-
- .settings-box.embedded {
- align-self: stretch;
- border-top: none;
- padding: 0;
- }
-
- div.subtitle {
+ .subtitle {
+ -webkit-margin-start: 20px;
font-weight: 500;
padding: 20px 0;
}
@@ -182,8 +173,8 @@
<!-- network -->
<div class="layout vertical"
hidden$="[[!hasNetworkSection_(networkProperties)]]">
- <div class="subtitle indented">Network</div>
+ <div class="subtitle">Network</div>
<!-- APN -->
<network-apnlist editable on-apn-change="onNetworkPropertyChange_"
hidden$="[[!isType_(networkProperties, NetworkType.CELLULAR)]]"
@@ -193,6 +184,7 @@
<network-ip-config editable on-ip-change="onIPConfigChange_"
network-properties="[[networkProperties]]">
</network-ip-config>
+
<!-- Nameservers -->
<network-nameservers editable
on-nameservers-change="onIPConfigChange_"
@@ -202,11 +194,9 @@
<!-- Proxy -->
<div class="subtitle">Proxy</div>
- <div id="proxyDiv" class="layout vertical">
- <network-proxy editable on-proxy-change="onProxyChange_"
- network-properties="[[networkProperties]]">
- </network-proxy>
- </div>
+ <network-proxy editable on-proxy-change="onProxyChange_"
+ network-properties="[[networkProperties]]">
+ </network-proxy>
</div>
</iron-collapse>
</template>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_shared_css.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698