Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/resources/settings/internet_page/network_apnlist.html

Issue 2179223004: MD Settings: Internet: Clean up network and proxy sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_609156_internet_cleanup_3
Patch Set: Minor fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
3 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l"> 3 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l">
4 <link rel="import" href="internet_shared_css.html">
4 <link rel="import" href="network_property_list.html"> 5 <link rel="import" href="network_property_list.html">
5 6
6 <dom-module id="network-apnlist"> 7 <dom-module id="network-apnlist">
7 <template> 8 <template>
8 <style> 9 <style include="internet-shared">
9 #outerDiv { 10 </style>
10 margin-bottom: 10px; 11 <div class="settings-box">
11 } 12 <div class="start">Access Point</div>
13 <paper-dropdown-menu vertical-align="auto" no-label-float>
14 <paper-listbox id="selectApn"
15 class="dropdown-content" on-iron-activate="onSelectApnChange_"
16 selected="{{selectedApn}}" attr-for-selected="value">
17 <template is="dom-repeat" items="[[apnSelectList]]">
18 <button class="dropdown-item" role="option"
19 value="[[item.AccessPointName]]">
dschuyler 2016/07/29 02:07:22 Can this line un-wrap?
stevenjb 2016/07/29 17:35:18 Er, not even close :) (Well, 89 chars...)
20 [[apnDesc_(item)]]
21 </button>
22 </template>
23 </paper-listbox>
24 </paper-dropdown-menu>
25 </div>
12 26
13 #selectDiv { 27 <div class="settings-box continuation single-column"
14 margin-bottom: 10px; 28 hidden$="[[!isOtherSelected_(networkProperties, selectedApn)]]">
15 } 29 <network-property-list on-property-change="onOtherApnChange_"
16 30 fields="[[otherApnFields_]]" property-dict="[[otherApn]]"
17 #selectDiv select { 31 edit-field-types="[[otherApnEditTypes_]]">
18 -webkit-margin-start: 10px; 32 </network-property-list>
19 padding: 5px; 33 <paper-button on-tap="onSaveOtherTap_">Save</paper-button>
20 }
21
22 #otherDiv network-property-list {
23 -webkit-margin-start: 15px;
24 }
25 </style>
26 <div id="outerDiv" class="layout vertical">
27 <div id="selectDiv" class="layout horizontal center">
28 <span>Access Point:</span>
29 <!-- TODO(stevenjb): Use cr-dropdown-menu once available. -->
30 <select id="selectApn" value="{{selectedApn::change}}"
31 on-change="onSelectApnChange_">
32 <template is="dom-repeat"
33 items="[[apnSelectList]]" on-dom-change="onSelectApnUpdated_">
34 <option value="[[item.AccessPointName]]">[[apnDesc_(item)]]</option>
35 </template>
36 </select>
37 </div>
38 <div id="otherDiv" class="layout vertical"
39 hidden$="[[!isOtherSelected_(networkProperties, selectedApn)]]">
40 <network-property-list
41 fields="[[otherApnFields_]]" property-dict="[[otherApn]]"
42 edit-field-types="[[otherApnEditTypes_]]"
43 on-property-change="onOtherApnChange_">
44 </network-property-list>
45 <paper-button on-tap="onSaveOtherTap_">Save</paper-button>
46 </div>
47 </div> 34 </div>
48 </template> 35 </template>
49 <script src="network_apnlist.js"></script> 36 <script src="network_apnlist.js"></script>
50 </dom-module> 37 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698