chrome/browser/resources/settings/internet_page/internet_shared_css.html - Issue 2179223004: MD Settings: Internet: Clean up network and proxy sections.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/internet_page/internet_shared_css.html

Issue 2179223004: MD Settings: Internet: Clean up network and proxy sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_609156_internet_cleanup_3

Patch Set: Minor fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_detail_page.html ('k') | chrome/browser/resources/settings/internet_page/network_apnlist.html » ('j') | chrome/browser/resources/settings/internet_page/network_apnlist.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="/settings_shared_css.html">

	2

	3 <!-- Common styles for Material Design settings. -->

	4 <dom-module id="internet-shared">

	5 <template>

	6 <style include="settings-shared">

	7 paper-input-container {

	8 --paper-input-container-input: {

	9 color: var(--paper-grey-600);

	10 font-size: 100%;
	dschuyler 2016/07/29 02:07:22 A font-size: 100%; just looks strange to me. Is th A font-size: 100%; just looks strange to me. Is this really overriding something? stevenjb 2016/07/29 17:35:18 paper-input-container applies --paper-font-subhead Show quoted text On 2016/07/29 02:07:22, dschuyler wrote: > A font-size: 100%; just looks strange to me. > Is this really overriding something? paper-input-container applies --paper-font-subhead to .input-content ::content input, which specifies a font size of 16px (see typography.html). This sets font-size to 100% of the default. I can use font-size: inherit instead which is equivalent in this case, but arguably more clear. Done.
	11 font-weight: 400;

	12 };

	13 margin-bottom: 0;

	14 margin-top: -9px;

	15 }

	16

	17 .indented {

	18 -webkit-margin-start: 20px;

	19 }

	20

	21 .settings-box.embedded {

	22 align-self: stretch;

	23 border-top: none;

	24 padding: 0;

	25 }
	dschuyler 2016/07/29 02:07:22 Is this something that could or should be used els Is this something that could or should be used elsewhere? I'm wondering if it should move to settings_shared_css.html. stevenjb 2016/07/29 17:35:18 Possibly. The only other place I do this is in dev Show quoted text On 2016/07/29 02:07:22, dschuyler wrote: > Is this something that could or should be > used elsewhere? I'm wondering if it should > move to settings_shared_css.html. Possibly. The only other place I do this is in device-page, but I do something slightly different there. I can move this and update device-page in a separate CL.
	26 </style>

	27 </template>

	28 </dom-module>

OLD	NEW