Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2179193002: Add test for WebBluetooth chooser spinner, status, and rescan button on Mac (Closed)

Created:
4 years, 5 months ago by juncai
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for WebBluetooth chooser spinner, status, and rescan button on Mac This is part 6 of matching WebBluetooth chooser views to mocks. This CL adds test code for spinner, status, and rescan button that was added in the previous patch. BUG=583452 Committed: https://crrev.com/d8f1f8c536e052a6cab47d6e1614749331fcc7f9 Cr-Commit-Position: refs/heads/master@{#408248}

Patch Set 1 : added test for WebBluetooth chooser spinner, status, and rescan button on Mac #

Patch Set 2 : updated comment #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 4 chunks +123 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (18 generated)
juncai
Please take a look.
4 years, 5 months ago (2016-07-25 22:21:33 UTC) #6
Robert Sesek
LGTM
4 years, 5 months ago (2016-07-25 23:03:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179193002/60001
4 years, 4 months ago (2016-07-27 21:43:27 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-27 21:47:06 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 21:48:37 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d8f1f8c536e052a6cab47d6e1614749331fcc7f9
Cr-Commit-Position: refs/heads/master@{#408248}

Powered by Google App Engine
This is Rietveld 408576698