Convert Ozone cast to directly create GLSurfaces.

Convert Ozone cast to directly create GLSurfaces.

The Ozone cast platform now directly creates an appropriate GLSurface
instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL
subclass and add a new GLSurface subclass.

BUG=611142
Committed: https://crrev.com/93a53b3c9b7c6e52090f9fa08de2ef7e278114c0
Cr-Commit-Position: refs/heads/master@{#408133}

[kylechar, 2016-07-26 16:12:17]

Description was changed from

==========
Convert Ozone Cast to to directly create GLSurfaces.

The Ozone Cast platform now directly creates an appropriate GLSurface
instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL
subclass and add a new GLSurface subclass.

BUG=611142
==========

to

==========
Convert Ozone cast to directly create GLSurfaces.

The Ozone cast platform now directly creates an appropriate GLSurface
instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL
subclass and add a new GLSurface subclass.

BUG=611142
==========

[kylechar, 2016-07-26 16:47:29]

Patchset #2 (id:20001) has been deleted

[kylechar, 2016-07-27 14:04:23]

kylechar@chromium.org changed reviewers:
+ halliwell@chromium.org

[halliwell, 2016-07-27 14:34:18]

lgtm % a question about offscreen surface case.

And as discussed, will unfortunately have to wait a couple weeks before we can
attempt running this on a device ... will let you know if we hit problems :)

https://codereview.chromium.org/2179163003/diff/40001/ui/ozone/platform/cast/...
File ui/ozone/platform/cast/surface_factory_cast.cc (right):

https://codereview.chromium.org/2179163003/diff/40001/ui/ozone/platform/cast/...
ui/ozone/platform/cast/surface_factory_cast.cc:197: return
gl::InitializeGLSurface(new gl::SurfacelessEGL(size));
Is this right?  Currently we go through the pbuffer codepath for offscreen
surface.

[kylechar, 2016-07-27 14:39:49]

Thanks! I changed the offscreen surface bit.

https://codereview.chromium.org/2179163003/diff/40001/ui/ozone/platform/cast/...
File ui/ozone/platform/cast/surface_factory_cast.cc (right):

https://codereview.chromium.org/2179163003/diff/40001/ui/ozone/platform/cast/...
ui/ozone/platform/cast/surface_factory_cast.cc:197: return
gl::InitializeGLSurface(new gl::SurfacelessEGL(size));
On 2016/07/27 14:34:18, halliwell wrote:
> Is this right?  Currently we go through the pbuffer codepath for offscreen
> surface.

Oops. Good catch, I will upload the new patch for real this time.

[kylechar, 2016-07-27 14:40:35]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-07-27 14:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2179163003/#ps60001
(title: "Change to PBuffer.")

[commit-bot: I haz the power, 2016-07-27 14:40:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 15:26:46]

Description was changed from

==========
Convert Ozone cast to directly create GLSurfaces.

The Ozone cast platform now directly creates an appropriate GLSurface
instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL
subclass and add a new GLSurface subclass.

BUG=611142
==========

to

==========
Convert Ozone cast to directly create GLSurfaces.

The Ozone cast platform now directly creates an appropriate GLSurface
instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL
subclass and add a new GLSurface subclass.

BUG=611142
==========

[commit-bot: I haz the power, 2016-07-27 15:26:47]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-27 15:29:22]

Description was changed from

==========
Convert Ozone cast to directly create GLSurfaces.

The Ozone cast platform now directly creates an appropriate GLSurface
instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL
subclass and add a new GLSurface subclass.

BUG=611142
==========

to

==========
Convert Ozone cast to directly create GLSurfaces.

The Ozone cast platform now directly creates an appropriate GLSurface
instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL
subclass and add a new GLSurface subclass.

BUG=611142

Committed: https://crrev.com/93a53b3c9b7c6e52090f9fa08de2ef7e278114c0
Cr-Commit-Position: refs/heads/master@{#408133}
==========

[commit-bot: I haz the power, 2016-07-27 15:29:23]

Patchset 3 (id:??) landed as
https://crrev.com/93a53b3c9b7c6e52090f9fa08de2ef7e278114c0
Cr-Commit-Position: refs/heads/master@{#408133}