Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3017)

Unified Diff: chrome/android/webapk/shell_apk/BUILD.gn

Issue 2179163002: Make HostBrowserClassLoader#getClassLoaderInstance() work if Chrome gets updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_chrome_updated Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/webapk/shell_apk/BUILD.gn
diff --git a/chrome/android/webapk/shell_apk/BUILD.gn b/chrome/android/webapk/shell_apk/BUILD.gn
index 4e0366742dc9abe784e7b897bb911cdccb7ce205..8605a80dd01ca0f13e691cfeda896fa1136010ab 100644
--- a/chrome/android/webapk/shell_apk/BUILD.gn
+++ b/chrome/android/webapk/shell_apk/BUILD.gn
@@ -63,18 +63,9 @@ android_resources("shell_apk_resources") {
custom_package = "org.chromium.webapk.shell_apk"
}
-android_library("dex_loader_java") {
- java_files = [ "src/org/chromium/webapk/shell_apk/DexLoader.java" ]
-}
-
-# Template for WebAPK. When a WebAPK is generated:
-# - Android manifest is customized to the website.
-# - App icon is extracted from the website and added to the APK's resources.
-android_apk("webapk") {
- android_manifest = shell_apk_manifest
- android_manifest_dep = ":shell_apk_manifest"
- apk_name = "WebApk.$webapk_manifest_package_origin"
+android_library("webapk_java") {
java_files = [
+ "src/org/chromium/webapk/shell_apk/DexLoader.java",
"src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java",
"src/org/chromium/webapk/shell_apk/MainActivity.java",
"src/org/chromium/webapk/shell_apk/NotificationSettingsLauncherActivity.java",
@@ -86,10 +77,21 @@ android_apk("webapk") {
"src/org/chromium/webapk/shell_apk/WebApkUtils.java",
]
deps = [
- ":dex_loader_java",
":shell_apk_resources",
"//chrome/android/webapk/libs/common:common_java",
]
+}
+
+# Template for WebAPK. When a WebAPK is generated:
+# - Android manifest is customized to the website.
+# - App icon is extracted from the website and added to the APK's resources.
+android_apk("webapk") {
+ android_manifest = shell_apk_manifest
+ android_manifest_dep = ":shell_apk_manifest"
+ apk_name = "WebApk.$webapk_manifest_package_origin"
+ deps = [
+ ":webapk_java",
+ ]
if (!is_java_debug) {
proguard_enabled = true
proguard_configs = [
@@ -104,7 +106,7 @@ android_library("shell_apk_javatests") {
java_files =
[ "javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java" ]
deps = [
- ":dex_loader_java",
+ ":webapk_java",
"//base:base_java",
"//base:base_java_test_support",
"//chrome/android/webapk/libs/common:common_java",
@@ -112,3 +114,12 @@ android_library("shell_apk_javatests") {
]
srcjar_deps = [ "javatests/dex_optimizer:dex_optimizer_service_aidl" ]
}
+
+junit_binary("webapk_shell_apk_junit_tests") {
+ java_files = [ "junit/src/org/chromium/webapk/shell_apk/HostBrowserClassLoaderTest.java" ]
+ deps = [
+ ":webapk_java",
+ "//base:base_junit_test_support",
+ "//chrome/android/webapk/libs/common:common_java",
+ ]
+}
« no previous file with comments | « no previous file | chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698