Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: tests/html/js_util_test.dart

Issue 2179153002: Fix analyzer warnings in js_util_test, skip js_util_test in csp mode and baseline expectations for … (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/html.status ('k') | tests/lib/analyzer/analyze_library.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/js_util_test.dart
diff --git a/tests/html/js_util_test.dart b/tests/html/js_util_test.dart
index b58e0aac059e60536cae9e85e186676a6803655f..b0130b24d6b6779daca7fbaa96e86cfc4d9f06f0 100644
--- a/tests/html/js_util_test.dart
+++ b/tests/html/js_util_test.dart
@@ -68,16 +68,16 @@ external bool checkMap(m, String, value);
external String stringify(o);
@JS('Node')
-external Function get JSNodeType;
+external get JSNodeType;
@JS('Element')
-external Function get JSElementType;
+external get JSElementType;
@JS('Text')
-external Function get JSTextType;
+external get JSTextType;
@JS('HTMLCanvasElement')
-external Function get JSHtmlCanvasElementType;
+external get JSHtmlCanvasElementType;
@JS()
class Foo {
@@ -88,7 +88,7 @@ class Foo {
}
@JS('Foo')
-external Function get JSFooType;
+external get JSFooType;
@JS()
@anonymous
@@ -106,7 +106,7 @@ class ExampleTypedLiteral {
}
@JS("Object.prototype.hasOwnProperty")
-external Function get _hasOwnProperty;
+external get _hasOwnProperty;
bool hasOwnProperty(o, String name) {
return js_util.callMethod(_hasOwnProperty, 'call', [o, name]);
« no previous file with comments | « tests/html/html.status ('k') | tests/lib/analyzer/analyze_library.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698