Revert 260201 "Give localserver time to shut down"

Revert 260201 "Give localserver time to shut down"

> Give localserver time to shut down
> 
> On machines with slow I/O, the localserver might not shut down immediately,
> wait for it if necessary.
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/145873004

TBR=sigbjorn@opera.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260300

[tim (not reviewing), 2014-03-28 23:32:26]

Committed patchset #1 manually as r260300 (tree was closed).

[tim (not reviewing), 2014-03-29 00:33:16]

Reverted as many WIN tests failed as follows:

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds...

[ RUN      ] LoginPromptBrowserTest.SupplyRedundantAuths
HTTP server started on 127.0.0.1:1317...
sending server_data: {"host": "127.0.0.1", "port": 1317} (35 bytes)
c:\b\build\slave\cr-win-rel\build\src\chrome\browser\ui\login\login_prompt_browsertest.cc(939):
error: Value of: test_server()->Stop()
  Actual: false
Expected: true[  FAILED  ]
LoginPromptBrowserTest.SupplyRedundantAuths, where TypeParam =  and
GetParam() =  (14907 ms)
[730/1083] LoginPromptBrowserTest.SupplyRedundantAuths (15098 ms)
[ RUN      ] LoginPromptBrowserTest.NoLoginPromptForXHRWithBadCredentials
HTTP server started on 127.0.0.1:1331...
sending server_data: {"host": "127.0.0.1", "port": 1331} (35 bytes)
c:\b\build\slave\cr-win-rel\build\src\chrome\browser\ui\login\login_prompt_browsertest.cc(1111):
error: Value of: test_server()->Stop()
  Actual: false
Expected: true[  FAILED  ]
LoginPromptBrowserTest.NoLoginPromptForXHRWithBadCredentials, where
TypeParam =  and GetParam() =  (13641 ms)
[731/1083] LoginPromptBrowserTest.NoLoginPromptForXHRWithBadCredentials
(13828 ms)
[ RUN      ]
LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentialsCancelled
HTTP server started on 127.0.0.1:1332...
sending server_data: {"host": "127.0.0.1", "port": 1332} (35 bytes)
c:\b\build\slave\cr-win-rel\build\src\chrome\browser\ui\login\login_prompt_browsertest.cc(1255):
error: Value of: test_server()->Stop()
  Actual: false
Expected: true[  FAILED  ]
LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentialsCancelled,
where TypeParam =  and GetParam() =  (13578 ms)



On Fri, Mar 28, 2014 at 4:32 PM, <tim@chromium.org> wrote:

> Committed patchset #1 manually as r260300 (tree was closed).
>
> https://codereview.chromium.org/217913002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.