add unittests for roundtripping premul

add unittests for roundtripping premul

BUG=skia:5579
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179123005

Committed: https://skia.googlesource.com/skia/+/eb560284c5a44389cd3f3b304839ea34a3e73398

[reed1, 2016-07-27 01:12:29]

Description was changed from

==========
add unittests for roundtripping premul

BUG=skia:
==========

to

==========
add unittests for roundtripping premul

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179123005
==========

[reed1, 2016-07-27 01:13:19]

Description was changed from

==========
add unittests for roundtripping premul

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179123005
==========

to

==========
add unittests for roundtripping premul

BUG=skia:5579
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179123005
==========

[reed1, 2016-07-27 01:13:38]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 01:13:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-07-27 01:14:27]

reed@google.com changed reviewers:
+ msarett@google.com, mtklein@google.com

[reed1, 2016-07-27 01:21:37]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-07-27 01:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-07-27 01:40:30]

Well that's confusing if these tests pass...

lgtm though.

https://codereview.chromium.org/2179123005/diff/20001/tests/ImageTest.cpp
File tests/ImageTest.cpp (right):

https://codereview.chromium.org/2179123005/diff/20001/tests/ImageTest.cpp#new...
tests/ImageTest.cpp:959: if (memcmp(a.getAddr32(0, y), b.getAddr32(0, y),
a.width() * sizeof(SkPMColor))) {
0 != ?

[mtklein, 2016-07-27 01:44:44]

The CQ bit was unchecked by mtklein@google.com

[reed1, 2016-07-27 01:54:46]

The CQ bit was checked by reed@google.com

[reed1, 2016-07-27 01:54:46]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2179123005/#ps40001
(title: "use 0 !=")

[commit-bot: I haz the power, 2016-07-27 01:54:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-07-27 01:55:12]

very confusing -- both tests pass :(
maybe the test is flawed somehow

[mtklein_C, 2016-07-27 02:01:49]

On 2016/07/27 at 01:55:12, reed wrote:
> very confusing -- both tests pass :(
> maybe the test is flawed somehow

hard to count to 256 wrong...

[commit-bot: I haz the power, 2016-07-27 02:42:07]

Description was changed from

==========
add unittests for roundtripping premul

BUG=skia:5579
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179123005
==========

to

==========
add unittests for roundtripping premul

BUG=skia:5579
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179123005

Committed:
https://skia.googlesource.com/skia/+/eb560284c5a44389cd3f3b304839ea34a3e73398
==========

[commit-bot: I haz the power, 2016-07-27 02:42:08]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/eb560284c5a44389cd3f3b304839ea34a3e73398