Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html

Issue 2179123004: DevTools: fix stick to bottom in console viewport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't stick onkeydown when prompt fills viewport Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../http/tests/inspector/inspector-test.js"></script>
4 <script src="../../http/tests/inspector/console-test.js"></script> 4 <script src="../../http/tests/inspector/console-test.js"></script>
5 <script> 5 <script>
6 function populateConsoleWithMessages(count) 6 function populateConsoleWithMessages(count)
7 { 7 {
8 for (var i = 0; i < count - 1; ++i) 8 for (var i = 0; i < count - 1; ++i)
9 console.log("Multiline\nMessage #" + i); 9 console.log("Multiline\nMessage #" + i);
10 console.log("hello %cworld", "color: blue"); 10 console.log("hello %cworld", "color: blue");
11 } 11 }
12 12
13 //# sourceURL=console-viewport-selection.html 13 //# sourceURL=console-viewport-selection.html
14 </script> 14 </script>
15 15
16 <script> 16 <script>
17 17
18 function test() 18 function test()
19 { 19 {
20 InspectorTest.fixConsoleViewportDimensions(600, 200); 20 var viewportHeight = 200;
21 InspectorTest.fixConsoleViewportDimensions(600, viewportHeight);
21 var consoleView = WebInspector.ConsoleView.instance(); 22 var consoleView = WebInspector.ConsoleView.instance();
22 var viewport = consoleView._viewport; 23 var viewport = consoleView._viewport;
23 const minimumViewportMessagesCount = 10; 24 const minimumViewportMessagesCount = 10;
24 const messagesCount = 150; 25 const messagesCount = 150;
25 const middleMessage = messagesCount / 2; 26 const middleMessage = messagesCount / 2;
26 var viewportMessagesCount; 27 var viewportMessagesCount;
27 28
28 logMessagesToConsole(messagesCount, () => InspectorTest.runTestSuite(testSui te)); 29 logMessagesToConsole(messagesCount, () => InspectorTest.runTestSuite(testSui te));
29 30
30 var testSuite = [ 31 var testSuite = [
31 function verifyViewportIsTallEnough(next) 32 function verifyViewportIsTallEnough(next)
32 { 33 {
33 viewport.invalidate(); 34 viewport.invalidate();
34 viewport.forceScrollItemToBeFirst(0); 35 viewport.forceScrollItemToBeFirst(0);
35 viewportMessagesCount = viewport.lastVisibleIndex() - viewport.first VisibleIndex() + 1; 36 viewportMessagesCount = viewport.lastVisibleIndex() - viewport.first VisibleIndex() + 1;
36 if (viewportMessagesCount < minimumViewportMessagesCount) { 37 if (viewportMessagesCount < minimumViewportMessagesCount) {
37 InspectorTest.addResult(String.sprintf("Test cannot be run as vi ewport is not tall enough. It is required to contain at least %d messages, but % d only fit", minimumViewportMessagesCount, viewportMessagesCount)); 38 InspectorTest.addResult(String.sprintf("Test cannot be run as vi ewport is not tall enough. It is required to contain at least %d messages, but % d only fit", minimumViewportMessagesCount, viewportMessagesCount));
38 InspectorTest.completeTest(); 39 InspectorTest.completeTest();
39 return; 40 return;
40 } 41 }
41 InspectorTest.addResult(String.sprintf("Viewport contains %d message s", viewportMessagesCount)); 42 InspectorTest.addResult(String.sprintf("Viewport contains %d message s", viewportMessagesCount));
42 next(); 43 next();
43 }, 44 },
44 45
45 function testScrollViewportToBottom(next) 46 function testScrollViewportToBottom(next)
46 { 47 {
47 consoleView._immediatelyScrollToBottom(); 48 consoleView._immediatelyScrollToBottom();
48 viewport.refresh(); 49 dumpAndContinue(next);
49 InspectorTest.addResult("Last visible message: " + viewport.lastVisi bleIndex());
50 next();
51 }, 50 },
52 51
53 function testConsoleSticksToBottom(next) 52 function testConsoleSticksToBottom(next)
54 { 53 {
55 logMessagesToConsole(messagesCount, onMessagesDumped); 54 logMessagesToConsole(messagesCount, onMessagesDumped);
56 55
57 function onMessagesDumped() 56 function onMessagesDumped()
58 { 57 {
59 viewport.invalidate(); 58 dumpAndContinue(next);
60 // Force refresh which has been scheduled via invalidate() metho d.
61 viewport.refresh();
62 InspectorTest.addResult("Last visible message: " + viewport.last VisibleIndex());
63 next();
64 } 59 }
65 }, 60 },
66 61
67 function testManualScrollDoesNotStickToBottom(next) 62 function testSmoothScrollDoesNotStickToBottom(next)
68 { 63 {
69 const manualScrollValue = 3; 64 InspectorTest.addSniffer(WebInspector.ConsoleView.prototype, "_updat eViewportStickinessForTest", onUpdateTimeout);
70 var initialScrollTop = viewport.element.scrollTop; 65 sendPageUp();
71 viewport.element.scrollTop = initialScrollTop - manualScrollValue; 66
72 viewport.refresh(); 67 function onUpdateTimeout()
73 var newScrollTop = viewport.element.scrollTop; 68 {
74 var isScrollPreserved = initialScrollTop - newScrollTop === manualSc rollValue; 69 dumpAndContinue(next);
75 InspectorTest.addResult("Scroll preserved: " + isScrollPreserved); 70 }
76 next();
77 }, 71 },
72
73 function testEscShouldNotJumpToBottom(next)
74 {
75 var keyEvent = InspectorTest.createKeyEvent("Escape");
76 viewport._contentElement.dispatchEvent(keyEvent);
77 dumpAndContinue(next);
78 },
79
80 function testTypingShouldJumpToBottom(next)
81 {
82 var keyEvent = InspectorTest.createKeyEvent("a");
83 viewport._contentElement.dispatchEvent(keyEvent);
84 consoleView._prompt._proxyElement.dispatchEvent(new Event('input'));
85
86 dumpAndContinue(next);
87 },
88
89 function testViewportMutationsShouldPreserveStickToBottom(next)
90 {
91 viewport._contentElement.children[1].innerText = "More than 2 lines: foo\n\nbar";
92 dumpAndContinue(onMessagesDumped);
93
94 function onMessagesDumped()
95 {
96 viewport.setStickToBottom(false);
97 viewport._contentElement.children[1].innerText = "More than 3 li nes: foo\n\n\nbar";
98 dumpAndContinue(next);
99 }
100 },
101
102 function testShouldNotJumpToBottomWhenPromptFillsEntireViewport(next)
103 {
104 var text = "Foo";
105 for (var i = 0; i < viewportHeight; i++)
106 text += "\n";
107 consoleView._promptElement.textContent = text;
108 WebInspector.ConsoleView.clearConsole();
109 viewport.element.scrollTop -= 10;
110
111 var keyEvent = InspectorTest.createKeyEvent("a");
112 viewport._contentElement.dispatchEvent(keyEvent);
113 consoleView._prompt._proxyElement.dispatchEvent(new Event('input'));
114
115 dumpAndContinue(next);
116 }
78 ]; 117 ];
79 118
119 function sendPageUp()
120 {
121 var keyEvent = InspectorTest.createKeyEvent("PageUp");
122 consoleView._prompt._proxyElement.dispatchEvent(keyEvent);
123 viewport.element.scrollTop -= 10;
124 }
125
126 function dumpAndContinue(callback)
127 {
128 viewport.refresh();
129 InspectorTest.addResult("Is at bottom: " + viewport.element.isScrolledTo Bottom() + ", should stick: " + viewport.stickToBottom());
130 callback();
131 }
132
80 function logMessagesToConsole(count, callback) 133 function logMessagesToConsole(count, callback)
81 { 134 {
82 var awaitingMessagesCount = count; 135 var awaitingMessagesCount = count;
83 function messageAdded() 136 function messageAdded()
84 { 137 {
85 if (!--awaitingMessagesCount) 138 if (!--awaitingMessagesCount)
86 callback(); 139 callback();
87 else 140 else
88 InspectorTest.addConsoleSniffer(messageAdded, false); 141 InspectorTest.addConsoleSniffer(messageAdded, false);
89 } 142 }
90 143
91 InspectorTest.addConsoleSniffer(messageAdded, false); 144 InspectorTest.addConsoleSniffer(messageAdded, false);
92 InspectorTest.evaluateInPage(String.sprintf("populateConsoleWithMessages (%d)", count)); 145 InspectorTest.evaluateInPage(String.sprintf("populateConsoleWithMessages (%d)", count));
93 } 146 }
94 } 147 }
95 </script> 148 </script>
96 </head> 149 </head>
97 <body onload="runTest()"> 150 <body onload="runTest()">
98 <p> 151 <p>
99 Verifies viewport stick-to-bottom behavior. 152 Verifies viewport stick-to-bottom behavior.
100 </p> 153 </p>
101 </body> 154 </body>
102 </html> 155 </html>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698