Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2179123003: Add a usecounter for a slotchange event listener (Closed)

Created:
4 years, 4 months ago by hayato
Modified:
4 years, 4 months ago
Reviewers:
tkent, Ilya Sherman, kochi
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a usecounter for a slotchange event listener Add a usecounter for an event listener which is registered for a slotchange event. Committed: https://crrev.com/94847d3f6f2e42dda6f8f97d21098cb5085ac31b Cr-Commit-Position: refs/heads/master@{#407743}

Patch Set 1 #

Patch Set 2 : rename Slotchange -> SlotChange #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
hayato
PTAL. Adding isherman@ for for histograms. Could you take a look?
4 years, 4 months ago (2016-07-26 04:54:24 UTC) #4
Ilya Sherman
histograms.xml lgtm
4 years, 4 months ago (2016-07-26 05:06:40 UTC) #7
hayato
rename Slotchange -> SlotChange
4 years, 4 months ago (2016-07-26 05:27:15 UTC) #8
kochi
LGTM
4 years, 4 months ago (2016-07-26 05:30:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179123003/20001
4 years, 4 months ago (2016-07-26 07:53:55 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 09:11:07 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 09:12:52 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94847d3f6f2e42dda6f8f97d21098cb5085ac31b
Cr-Commit-Position: refs/heads/master@{#407743}

Powered by Google App Engine
This is Rietveld 408576698