Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2179093002: [Sync] No two error messages at same time (Closed)

Created:
4 years, 5 months ago by Gang Wu
Modified:
4 years, 5 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No two error messages at same time. BUG=628161 When set one of TextEdit, which are mEnterPassphrase and mConfirmPassphrase, to have an error message, set another one to empty. Committed: https://crrev.com/be517ca4aa6a819cb23427d46f79e4e4e6c43537 Cr-Commit-Position: refs/heads/master@{#407669}

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Gang Wu
PTAL
4 years, 5 months ago (2016-07-26 00:13:10 UTC) #6
maxbogue
lgtm
4 years, 5 months ago (2016-07-26 00:37:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179093002/20001
4 years, 5 months ago (2016-07-26 00:38:47 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-26 01:18:48 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 01:20:16 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be517ca4aa6a819cb23427d46f79e4e4e6c43537
Cr-Commit-Position: refs/heads/master@{#407669}

Powered by Google App Engine
This is Rietveld 408576698