Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: services/ui/public/cpp/tests/window_tree_client_unittest.cc

Issue 2179083002: mash: Fix system tray bubble not closing for clicks outside its bounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/cpp/tests/window_tree_client_unittest.cc
diff --git a/services/ui/public/cpp/tests/window_tree_client_unittest.cc b/services/ui/public/cpp/tests/window_tree_client_unittest.cc
index 5766f754a24bdfece1d6762111ca939c985b4d85..c7a593cb9aa13eb9c4309e234c9fe2c256ae1d5a 100644
--- a/services/ui/public/cpp/tests/window_tree_client_unittest.cc
+++ b/services/ui/public/cpp/tests/window_tree_client_unittest.cc
@@ -481,13 +481,14 @@ TEST_F(WindowTreeClientTest, OnEventObserved) {
// Simulate the server sending an observed event.
uint32_t event_observer_id = setup.GetEventObserverId();
- std::unique_ptr<ui::Event> ui_event(
- new ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), ui::EF_CONTROL_DOWN, 0));
- setup.window_tree_client()->OnEventObserved(ui::Event::Clone(*ui_event.get()),
+ ui::PointerEvent ui_event(
+ ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), ui::EF_CONTROL_DOWN, 0,
+ ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE),
+ ui::EventTimeForNow());
+ setup.window_tree_client()->OnEventObserved(ui::Event::Clone(ui_event),
event_observer_id);
- // Delegate sensed the event.
+ // Delegate sensed the event and it has been converted to a mouse down.
ui::Event* last_event = setup.window_tree_delegate()->last_event_observed();
EXPECT_EQ(ui::ET_MOUSE_PRESSED, last_event->type());
EXPECT_EQ(ui::EF_CONTROL_DOWN, last_event->flags());
@@ -497,7 +498,7 @@ TEST_F(WindowTreeClientTest, OnEventObserved) {
setup.client()->SetEventObserver(nullptr);
// Simulate another event from the server.
- setup.window_tree_client()->OnEventObserved(ui::Event::Clone(*ui_event.get()),
+ setup.window_tree_client()->OnEventObserved(ui::Event::Clone(ui_event),
event_observer_id);
// No event was sensed.
@@ -518,9 +519,10 @@ TEST_F(WindowTreeClientTest, OnWindowInputEventWithEventObserver) {
// Simulate the server dispatching an event that also matched the observer.
uint32_t event_observer_id = setup.GetEventObserverId();
- std::unique_ptr<ui::Event> ui_event(
- new ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), ui::EF_CONTROL_DOWN, 0));
+ std::unique_ptr<ui::Event> ui_event(new ui::PointerEvent(
+ ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), ui::EF_CONTROL_DOWN, 0,
+ ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE),
+ ui::EventTimeForNow()));
setup.window_tree_client()->OnWindowInputEvent(
1, server_id(root), std::move(ui_event), event_observer_id);
@@ -553,9 +555,10 @@ TEST_F(WindowTreeClientTest, EventObserverReplaced) {
// Simulate the server sending an observed event that matched the old observer
// (e.g. that was in-flight when the observer was replaced).
- std::unique_ptr<ui::Event> pressed_event(
- new ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), ui::EF_NONE, 0));
+ std::unique_ptr<ui::Event> pressed_event(new ui::PointerEvent(
+ ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), ui::EF_NONE, 0,
+ ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE),
+ ui::EventTimeForNow()));
setup.window_tree_client()->OnEventObserved(std::move(pressed_event),
event_observer_id1);
@@ -563,9 +566,10 @@ TEST_F(WindowTreeClientTest, EventObserverReplaced) {
EXPECT_FALSE(setup.window_tree_delegate()->last_event_observed());
// Simulate another event that matches the new observer.
- std::unique_ptr<ui::Event> released_event(
- new ui::MouseEvent(ui::ET_MOUSE_RELEASED, gfx::Point(), gfx::Point(),
- ui::EventTimeForNow(), ui::EF_CONTROL_DOWN, 0));
+ std::unique_ptr<ui::Event> released_event(new ui::PointerEvent(
+ ui::ET_POINTER_UP, gfx::Point(), gfx::Point(), ui::EF_CONTROL_DOWN, 0,
+ ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE),
+ ui::EventTimeForNow()));
setup.window_tree_client()->OnEventObserved(std::move(released_event),
event_observer_id2);

Powered by Google App Engine
This is Rietveld 408576698