Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2179083002: mash: Fix system tray bubble not closing for clicks outside its bounds (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 4 months ago
Reviewers:
msw, Hadi
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Fix system tray bubble not closing for clicks outside its bounds * Event observers need to convert pointer down events to mouse down events, just like they do for normal window input events. * Convert the event observer unit tests to simulate pointer events being sent from the window server, which is a better representation of how the system works in production. BUG=631126 TEST=mus_public_unittests

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix target #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -18 lines) Patch
M services/ui/public/cpp/lib/window_tree_client.cc View 1 3 chunks +14 lines, -2 lines 0 comments Download
M services/ui/public/cpp/tests/window_tree_client_unittest.cc View 1 6 chunks +30 lines, -16 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
James Cook
moshayedi, please take a look.
4 years, 5 months ago (2016-07-25 18:06:48 UTC) #2
Hadi
https://codereview.chromium.org/2179083002/diff/1/services/ui/public/cpp/lib/window_tree_client.cc File services/ui/public/cpp/lib/window_tree_client.cc (right): https://codereview.chromium.org/2179083002/diff/1/services/ui/public/cpp/lib/window_tree_client.cc#newcode602 services/ui/public/cpp/lib/window_tree_client.cc:602: nullptr /* target */); Why are we ignoring the ...
4 years, 5 months ago (2016-07-25 19:01:42 UTC) #3
James Cook
moshayedi, please take another look. https://codereview.chromium.org/2179083002/diff/1/services/ui/public/cpp/lib/window_tree_client.cc File services/ui/public/cpp/lib/window_tree_client.cc (right): https://codereview.chromium.org/2179083002/diff/1/services/ui/public/cpp/lib/window_tree_client.cc#newcode602 services/ui/public/cpp/lib/window_tree_client.cc:602: nullptr /* target */); ...
4 years, 5 months ago (2016-07-25 20:23:37 UTC) #4
Hadi
lgtm
4 years, 4 months ago (2016-07-26 14:00:30 UTC) #9
James Cook
msw, can I get OWNERS?
4 years, 4 months ago (2016-07-26 16:02:48 UTC) #11
James Cook
4 years, 4 months ago (2016-07-26 16:48:23 UTC) #16
On 2016/07/26 16:02:48, James Cook wrote:
> msw, can I get OWNERS?

Nevermind. Abandoning this patch per discussion in
https://bugs.chromium.org/p/chromium/issues/detail?id=631126 -- PointerWatchers
should get pointer events.

Powered by Google App Engine
This is Rietveld 408576698