Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2179053002: Revert of Hack to fix settings-checkbox mixin for 1.6.0 (Closed)

Created:
4 years, 5 months ago by michaelpg
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Polymer160
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Hack to fix settings-checkbox mixin for 1.6.0 (patchset #2 id:20001 of https://codereview.chromium.org/2168383003/ ) Reason for revert: Not required if we disable useNativeCSSProperties for 1.6.0. Original issue's description: > Hack to fix settings-checkbox mixin for 1.6.0 > > BUG= > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/8f718e9ac7ba2194633a6a827a0dbc57570714a7 > Cr-Commit-Position: refs/heads/master@{#407347} TBR=dbeam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/ee177cde6f47e9e834fa5e3eda481bedb70215df Cr-Commit-Position: refs/heads/master@{#407708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
michaelpg
Created Revert of Hack to fix settings-checkbox mixin for 1.6.0
4 years, 5 months ago (2016-07-25 17:15:23 UTC) #1
michaelpg
4 years, 5 months ago (2016-07-25 17:16:20 UTC) #2
Dan Beam
lgtm
4 years, 5 months ago (2016-07-25 20:52:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179053002/1
4 years, 5 months ago (2016-07-26 03:49:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 04:38:47 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 04:40:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee177cde6f47e9e834fa5e3eda481bedb70215df
Cr-Commit-Position: refs/heads/master@{#407708}

Powered by Google App Engine
This is Rietveld 408576698