Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 2179043002: Improve readability of StripLayoutHelper#setAccessibilityDescription logic. (Closed)

Created:
4 years, 5 months ago by bhallam
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve readability of StripLayoutHelper#setAccessibilityDescription logic. The current logic to add accessibility description for tabs was not very read-able and did not match existing code style of the project. This change cleans up the complex if-else conditions to a much simpler ternary assignment format. BUG=0 TEST=Re-run junit tests for StripLayoutHelperTest suite. Committed: https://crrev.com/13795ecb099ae0134017281028152254b9ac489c Cr-Commit-Position: refs/heads/master@{#408229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java View 2 chunks +14 lines, -11 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperTest.java View 8 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bhallam
Hi David, Can you please take a look at this patch. Thanks! Mohit
4 years, 5 months ago (2016-07-25 17:08:05 UTC) #3
David Trainor- moved to gerrit
lgtm thanks for updating :)
4 years, 4 months ago (2016-07-27 17:33:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179043002/1
4 years, 4 months ago (2016-07-27 20:04:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 20:40:16 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 20:43:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13795ecb099ae0134017281028152254b9ac489c
Cr-Commit-Position: refs/heads/master@{#408229}

Powered by Google App Engine
This is Rietveld 408576698