content/common/mojo/mojo_shell_connection_impl.cc - Issue 2179023004: Make Service own ServiceContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/mojo/mojo_shell_connection_impl.cc

Issue 2179023004: Make Service own ServiceContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/mojo/mojo_shell_connection_impl.cc

diff --git a/content/common/mojo/mojo_shell_connection_impl.cc b/content/common/mojo/mojo_shell_connection_impl.cc

index fe14742c75a68b53a664d234bf81ecbc0e257f1c..1295ab60cc5d0889f9d4d35b0bdee2a10795d92d 100644

--- a/content/common/mojo/mojo_shell_connection_impl.cc

+++ b/content/common/mojo/mojo_shell_connection_impl.cc

@@ -150,9 +150,7 @@ class MojoShellConnectionImpl::IOThreadContext

/////////////////////////////////////////////////////////////////////////////

// shell::Service implementation

- void OnStart(shell::Connector* connector,

- const shell::Identity& identity,

- uint32_t id) override {

+ void OnStart(const shell::Identity& identity) override {

DCHECK(io_thread_checker_.CalledOnValidThread());

DCHECK(!initialize_handler_.is_null());