Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: services/shell/tests/shell/driver.cc

Issue 2179023004: Make Service own ServiceContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/tests/shell/OWNERS ('k') | services/shell/tests/shell/shell_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/shell/tests/shell/driver.cc
diff --git a/services/shell/tests/shell/driver.cc b/services/shell/tests/shell/driver.cc
index 6155bbcb29f8944c5b80c36c5aa6f967376fbf48..b78d174fc552b6014d1a9c9c72e13bfce50408a4 100644
--- a/services/shell/tests/shell/driver.cc
+++ b/services/shell/tests/shell/driver.cc
@@ -45,9 +45,7 @@ class Driver : public shell::Service,
private:
// shell::Service:
- void OnStart(shell::Connector* connector,
- const shell::Identity& identity,
- uint32_t id) override {
+ void OnStart(const shell::Identity& identity) override {
base::FilePath target_path;
CHECK(base::PathService::Get(base::DIR_EXE, &target_path));
#if defined(OS_WIN)
@@ -84,7 +82,8 @@ class Driver : public shell::Service,
shell::Connector::ConnectParams params(target);
params.set_client_process_connection(std::move(client),
GetProxy(&receiver));
- std::unique_ptr<shell::Connection> connection = connector->Connect(&params);
+ std::unique_ptr<shell::Connection> connection =
+ connector()->Connect(&params);
connection->AddConnectionCompletedClosure(
base::Bind(&Driver::OnConnectionCompleted, base::Unretained(this)));
« no previous file with comments | « services/shell/tests/shell/OWNERS ('k') | services/shell/tests/shell/shell_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698