services/shell/public/cpp/lib/service_context.cc - Issue 2179023004: Make Service own ServiceContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/public/cpp/lib/service_context.cc

Issue 2179023004: Make Service own ServiceContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/shell/public/cpp/lib/service_context.cc

diff --git a/services/shell/public/cpp/lib/service_context.cc b/services/shell/public/cpp/lib/service_context.cc

index 1a9cd42932eea375008caf02c5bd97e73f185f52..ed05b644a03d144fab6dfe551b0af06746229166 100644

--- a/services/shell/public/cpp/lib/service_context.cc

+++ b/services/shell/public/cpp/lib/service_context.cc

@@ -60,7 +60,7 @@ void ServiceContext::OnStart(mojom::IdentityPtr identity,

binding_.set_connection_error_handler(

base::Bind(&ServiceContext::OnConnectionError, base::Unretained(this)));

- service_->OnStart(connector_.get(), identity_, id);

+ service_->OnStart(identity_);

}

void ServiceContext::OnConnect(