Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2179023003:
Fix docs for checking out Skia (Closed)
DescriptionFix docs for checking out Skia
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179023003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2179023003
Committed: https://skia.googlesource.com/skia/+/917d6f3005d36d48d5cf0504920405d32e8307ce
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address comments #Messages
Total messages: 17 (7 generated)
Description was changed from ========== Fix docs for checking out Skia BUG=skia: ========== to ========== Fix docs for checking out Skia BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179023003 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2179023003 ==========
borenet@google.com changed reviewers: + borenet@google.com, hcm@google.com, jcgregorio@google.com
mtklein@google.com changed reviewers: + mtklein@google.com
fwiw, the existing checkout instructions are how we developers typically make a checkout. no one likes having to nest skia/ inside another directory.
On 2016/07/26 14:24:17, mtklein wrote: > fwiw, the existing checkout instructions are how we developers typically make a > checkout. no one likes having to nest skia/ inside another directory. Joe's got me on board. Don't we want an unmanaged checkout, e.g. using --unmanaged or `fetch skia`?
https://codereview.chromium.org/2179023003/diff/1/site/user/download.md File site/user/download.md (right): https://codereview.chromium.org/2179023003/diff/1/site/user/download.md#newco... site/user/download.md:24: gclient config https://skia.googlesource.com/skia.git Probably want a mkdir src/; cd src too? It gets really confusing to have .gclient in a non-dedicated directory like ~.
Good catch with --unmanaged. I thought it was the default as of a long time ago. https://codereview.chromium.org/2179023003/diff/1/site/user/download.md File site/user/download.md (right): https://codereview.chromium.org/2179023003/diff/1/site/user/download.md#newco... site/user/download.md:24: gclient config https://skia.googlesource.com/skia.git On 2016/07/26 14:57:54, mtklein wrote: > Probably want a mkdir src/; cd src too? > It gets really confusing to have .gclient in a non-dedicated directory like ~. Done.
I think it's the default as used by fetch, but not the real default. lgtm
Description was changed from ========== Fix docs for checking out Skia BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179023003 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2179023003 ========== to ========== Fix docs for checking out Skia BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179023003 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2179023003 ==========
On 2016/07/26 18:02:12, mtklein wrote: > I think it's the default as used by fetch, but not the real default. > > lgtm cc Hal as we've gone back and forth about these docs a few times in the past lgtm
The CQ bit was checked by borenet@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix docs for checking out Skia BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179023003 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2179023003 ========== to ========== Fix docs for checking out Skia BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179023003 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2179023003 Committed: https://skia.googlesource.com/skia/+/917d6f3005d36d48d5cf0504920405d32e8307ce ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/917d6f3005d36d48d5cf0504920405d32e8307ce
Message was sent while issue was closed.
halcanary@google.com changed reviewers: + halcanary@google.com
Message was sent while issue was closed.
I won't fight this anymore.
cd ~/src
mkdir tmpskia
mv skia tmpskia
mv tmpskia skia
|
