cc: disable denorm handling before calling into Skia's filter code.

cc: disable denorm handling before calling into Skia's filter code.

Set the "denorms-are-zero" and "flush-to-zero" CSR flags prior to
calling into Skia's filter code.

BUG=615851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/014a9a0ea7260b37773adb545b7cabbff80423b9
Cr-Commit-Position: refs/heads/master@{#407823}

[Stephen White, 2016-07-25 20:15:53]

Description was changed from

==========
cc: disable denorm handling before calling into Skia's filter code.

Set the "denorms-are-zero" and "flush-to-zero" CSR flags prior to
calling into Skia's filter code.

BUG=615851
==========

to

==========
cc: disable denorm handling before calling into Skia's filter code.

Set the "denorms-are-zero" and "flush-to-zero" CSR flags prior to
calling into Skia's filter code.

BUG=615851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[Stephen White, 2016-07-25 20:16:31]

Description was changed from

==========
cc: disable denorm handling before calling into Skia's filter code.

Set the "denorms-are-zero" and "flush-to-zero" CSR flags prior to
calling into Skia's filter code.

BUG=615851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: disable denorm handling before calling into Skia's filter code.

Set the "denorms-are-zero" and "flush-to-zero" CSR flags prior to
calling into Skia's filter code.

BUG=615851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[Stephen White, 2016-07-25 20:16:31]

senorblanco@chromium.org changed reviewers:
+ piman@chromium.org

[Stephen White, 2016-07-25 20:18:54]

piman@: PTAL.

See the referenced bug for background.

[piman, 2016-07-25 20:28:40]

https://codereview.chromium.org/2179003003/diff/20001/cc/playback/raster_sour...
File cc/playback/raster_source.cc (right):

https://codereview.chromium.org/2179003003/diff/20001/cc/playback/raster_sour...
cc/playback/raster_source.cc:84: #endif
This may be needed in more places - e.g. software renderer. Also, we may end up
needing an ARM version. Do you think it could make sense to make a
ScopedFlushSubnormalsToZero in some header (forces flush-to-zero in constructor,
restore in destructor), and use it here?

[Stephen White, 2016-07-25 20:36:27]

On 2016/07/25 20:28:40, piman - slow reviews until 8-8 wrote:
>
https://codereview.chromium.org/2179003003/diff/20001/cc/playback/raster_sour...
> File cc/playback/raster_source.cc (right):
> 
>
https://codereview.chromium.org/2179003003/diff/20001/cc/playback/raster_sour...
> cc/playback/raster_source.cc:84: #endif
> This may be needed in more places - e.g. software renderer. Also, we may end
up
> needing an ARM version. Do you think it could make sense to make a
> ScopedFlushSubnormalsToZero in some header (forces flush-to-zero in
constructor,
> restore in destructor), and use it here?

A guard is a good idea. I was thinking about putting something in base/, but
perhaps just cc/ 
is good enough for now. WRT software renderer, this fix seems to work for
--disable-gpu as well.
Is there another way I should be testing?

I do have an ARM flavour. I couldn't reproduce the problem on Android, but I
didn't try with --disable-main-frame-before-activation (necessary to repro);
I'll give
that a try.

[Stephen White, 2016-07-25 21:08:06]

New patch up: moved to a scoped guard class in cc/base/math_utils.cc (let me
know if there's a better place). Also implemented in software renderer.

[piman, 2016-07-26 00:32:39]

LGTM, thanks!

[mtklein_C, 2016-07-26 00:35:57]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-07-26 00:35:58]

Very tidy!

[mtklein_C, 2016-07-26 00:36:26]

mtklein@chromium.org changed reviewers:
- mtklein@chromium.org

[Stephen White, 2016-07-26 14:08:35]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2016-07-26 14:08:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 14:09:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 14:09:35]

Try jobs failed on following builders:
  linux_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

[Stephen White, 2016-07-26 14:49:11]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2016-07-26 14:49:12]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2179003003/#ps60001
(title: "Protect orig_state_ member var with #ifdef __SSE__.")

[commit-bot: I haz the power, 2016-07-26 14:49:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 14:50:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 14:50:33]

Try jobs failed on following builders:
  linux_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

[Stephen White, 2016-07-26 15:40:09]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2016-07-26 15:40:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 16:19:03]

Description was changed from

==========
cc: disable denorm handling before calling into Skia's filter code.

Set the "denorms-are-zero" and "flush-to-zero" CSR flags prior to
calling into Skia's filter code.

BUG=615851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: disable denorm handling before calling into Skia's filter code.

Set the "denorms-are-zero" and "flush-to-zero" CSR flags prior to
calling into Skia's filter code.

BUG=615851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-26 16:19:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-26 16:20:39]

Description was changed from

==========
cc: disable denorm handling before calling into Skia's filter code.

Set the "denorms-are-zero" and "flush-to-zero" CSR flags prior to
calling into Skia's filter code.

BUG=615851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: disable denorm handling before calling into Skia's filter code.

Set the "denorms-are-zero" and "flush-to-zero" CSR flags prior to
calling into Skia's filter code.

BUG=615851
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/014a9a0ea7260b37773adb545b7cabbff80423b9
Cr-Commit-Position: refs/heads/master@{#407823}
==========

[commit-bot: I haz the power, 2016-07-26 16:20:40]

Patchset 4 (id:??) landed as
https://crrev.com/014a9a0ea7260b37773adb545b7cabbff80423b9
Cr-Commit-Position: refs/heads/master@{#407823}