Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 21790002: drive: Discard upload location when there is no uploaded contents (Closed)

Created:
7 years, 4 months ago by hashimoto
Modified:
7 years, 4 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tzik
Visibility:
Public.

Description

drive: Discard upload location when GetUploadStatus fails GetUploadStatus for an unusable URL always results in an error. Upload location should be discarded to initiate new upload in such cases. BUG=267452 R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215801

Patch Set 1 : #

Patch Set 2 : Changed approach #

Patch Set 3 : Add UploadFileInfo::next_start_position #

Patch Set 4 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -12 lines) Patch
M chrome/browser/drive/drive_uploader.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/drive/drive_uploader.cc View 1 2 8 chunks +22 lines, -10 lines 0 comments Download
M chrome/browser/drive/drive_uploader_unittest.cc View 1 2 3 2 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
hashimoto
kinaba@ please review. tzik@ jfyi
7 years, 4 months ago (2013-08-02 09:57:52 UTC) #1
kinaba
lgtm
7 years, 4 months ago (2013-08-02 10:36:59 UTC) #2
hashimoto
Changed the approach to discard the upload location when GetUploadStatus() fails. PTAL
7 years, 4 months ago (2013-08-05 04:36:22 UTC) #3
hashimoto
Patch Set 2 did not pay attention for non-resume case and always discarded the upload ...
7 years, 4 months ago (2013-08-06 01:30:53 UTC) #4
kinaba
lgtm
7 years, 4 months ago (2013-08-06 01:42:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/21790002/31001
7 years, 4 months ago (2013-08-06 01:48:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=155755
7 years, 4 months ago (2013-08-06 02:40:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/21790002/31001
7 years, 4 months ago (2013-08-06 03:05:24 UTC) #8
hashimoto
Oops, the test is broken. Fixed, PTAL.
7 years, 4 months ago (2013-08-06 03:20:26 UTC) #9
kinaba
lgtm
7 years, 4 months ago (2013-08-06 03:21:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/21790002/56001
7 years, 4 months ago (2013-08-06 04:06:52 UTC) #11
hashimoto
7 years, 4 months ago (2013-08-06 05:44:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 manually as r215801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698