content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java - Issue 2178973004: DialogSurfaceManager implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

Issue 2178973004: DialogSurfaceManager implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/BUILD.gn ('k') | content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java » ('j') | content/public/android/java/src/org/chromium/content/browser/androidoverlay/AndroidOverlayProviderImpl.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

index fde50c8f4b2427b5b341b8026ae88bbb11505a8f..ce0c482401991132255a06050d5f2277b14feba4 100644

--- a/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

+++ b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java

@@ -397,6 +397,17 @@ public class ChildProcessServiceImpl {

}

+ @SuppressWarnings("unused")

+ @CalledByNative

+ private IBinder getAndroidOverlayProvider() {

+ try {

boliu 2017/02/08 00:01:58 all the other calls have a null check for mCallbac

+ return mCallback.getAndroidOverlayProvider();

+ } catch (RemoteException e) {

+ Log.e(TAG, "Unable to call getAndroidOverlayProvider: %s", e);

+ return null;

+ }

/**

* Helper for registering FileDescriptorInfo objects with GlobalFileDescriptors.

* This includes the IPC channel, the crash dump signals and resource related