content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl - Issue 2178973004: DialogSurfaceManager implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

Issue 2178973004: DialogSurfaceManager implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed whitespace changes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/DialogSurfaceActivityMapper.java ('K') | « content/public/android/java/src/org/chromium/content/browser/DialogSurfaceActivityMapper.java ('k') | gpu/ipc/common/BUILD.gn » ('j') | media/base/android/dialog_surface_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

diff --git a/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl b/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

index bf298858130d144ef147c11c16498a9f33f0d0f5..518dc1ab69f8225ac7990820889f540f7140060a 100644

--- a/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

+++ b/content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl

@@ -24,4 +24,7 @@ interface IChildProcessCallback {

void unregisterSurfaceTextureSurface(int surfaceTextureId, int clientId);

SurfaceWrapper getSurfaceTextureSurface(int surfaceTextureId);

+ // Return the DialogSurfaceManager instance.

+ IBinder getDialogSurfaceManager();

boliu 2016/11/14 16:39:25 hmm, surprising that aidl security review isn't en

liberato (no reviews please) 2016/12/20 17:16:38 good catch. i'll make sure that these get reviewe

}