DialogSurfaceManager implementation.

content/browser/media/android/dialog_surface_activity_mapper.cc

Index: content/browser/media/android/dialog_surface_activity_mapper.cc
diff --git a/content/browser/media/android/dialog_surface_activity_mapper.cc b/content/browser/media/android/dialog_surface_activity_mapper.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6a57fe9b56a77795437a76e82b8af1336dcef004
--- /dev/null
+++ b/content/browser/media/android/dialog_surface_activity_mapper.cc
@@ -0,0 +1,59 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/media/android/dialog_surface_activity_mapper.h"
+
+// TODO(liberato): browser_media_player_manager only does this if !USE_AURA
+#include "content/browser/android/content_view_core_impl.h"
+#include "content/browser/frame_host/render_frame_host_impl.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/web_contents.h"
+#include "jni/DialogSurfaceActivityMapper_jni.h"
+
+using namespace content;

[DaleCurtis, 2016/07/27 18:14:19]

We don't typically use "using"

[liberato (no reviews please), 2016/07/28 15:33:30]

Done.

+
+static ScopedJavaLocalRef<jobject> GetContentViewCore(

[DaleCurtis, 2016/07/27 18:14:19]

Seems unused? It looks like you're calling this from Java, but does this really
link properly? Is it possible to bind the process id into this instead of
iterating for it?

[liberato (no reviews please), 2016/07/28 15:33:30]

I don't think that it's called right now, since it's part of
DialogSurfaceManager::Create that's omitted.  the full CL shows its use, but
it's uninteresting.

i could split out DialogSurfaceActivityMapper into a separate CL, i suppose, now
that i look at it.  its connection to SurfaceManager is easily removed.

bind process id: i don't think so.  this code is more or less copied from
similar logic for SurfaceTexturePeer:
https://cs.chromium.org/chromium/src/content/browser/media/android/browser_me...

in short, the pid comes via ipc and there's nothing exposed that I can see to
convert to id.

+    JNIEnv* env,
+    const JavaParamRef<jclass>& jcaller,
+    jint renderer_pid,
+    jint render_frame_id) {
+  base::android::ScopedJavaLocalRef<jobject> nullref;

[DaleCurtis, 2016/07/27 18:14:19]

Does return nullptr fail?

[liberato (no reviews please), 2016/07/28 15:33:30]

unfortunately, yes.  i hadn't tried it, though, so good catch anyway.

+
+  // Get the id from the handle.  On android, the handle is the pid.
+  RenderProcessHost::iterator it = RenderProcessHost::AllHostsIterator();
+  int render_process_id = 0;
+  while (!it.IsAtEnd()) {
+    if (it.GetCurrentValue()->GetHandle() == renderer_pid) {
+      render_process_id = it.GetCurrentValue()->GetID();
+      break;
+    }
+    it.Advance();
+  }
+  if (!render_process_id) {
+    DVLOG(1) << "Cannot find render process for renderer_pid " << renderer_pid;
+    return nullref;
+  }
+
+  // Get the frame from the id.
+  RenderFrameHostImpl* frame =
+      RenderFrameHostImpl::FromID(render_process_id, render_frame_id);
+  if (!frame)
+    return nullref;
+
+  WebContents* web_contents = WebContents::FromRenderFrameHost(frame);
+  if (!web_contents)
+    return nullref;
+
+  ContentViewCore* cvc = ContentViewCoreImpl::FromWebContents(web_contents);
+  if (!cvc)
+    return nullref;
+
+  return base::android::ScopedJavaLocalRef<jobject>(cvc->GetJavaObject());
+}
+
+namespace content {
+bool RegisterDialogSurfaceActivityMapper(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}
+}