DialogSurfaceManager implementation.

media/base/android/java/src/org/chromium/media/DialogSurfaceWrapper.java

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.media;
+
+import android.os.IBinder;
+import android.os.RemoteException;
+
+import org.chromium.base.annotations.CalledByNative;
+import org.chromium.base.annotations.JNINamespace;
+
+/**
+ * Wrapper for IDialogSurface for JNI bindings.
+ *
+ * Makes any implementation of IDialogSurface accessible through JNI.
+ * Doesn't have to implement IDialogSurface, except that it's an easy
+ * way to keep the interface in sync.
+ */
+@JNINamespace("media")
+class DialogSurfaceWrapper implements IDialogSurface {
+    private final IDialogSurface mDialogSurface;
+
+    public DialogSurfaceWrapper(IDialogSurface surface) {

[boliu, 2017/01/04 01:48:45]

private?

[liberato (no reviews please), 2017/01/11 22:17:58]

good point, done.

+        mDialogSurface = surface;
+    }
+
+    @CalledByNative
+    private static DialogSurfaceWrapper wrap(IDialogSurface surface) {
+        return new DialogSurfaceWrapper(surface);
+    }
+
+    @Override
+    @CalledByNative
+    public void release() throws RemoteException {

[boliu, 2017/01/04 01:48:44]

throwing exception doesn't really work for CalledByNative methods. any exception
will just immediately crash in native code

it's probably ok to swallow these exceptions I imagine? so can do that in java
code, or need to return some kind of error code to native side if that's
required

[liberato (no reviews please), 2017/01/11 22:17:58]

yeah, they can be ignored.

+        mDialogSurface.release();
+    }
+
+    @Override
+    @CalledByNative
+    public void scheduleLayoutSurface(final int x, final int y, final int width, final int height)
+            throws RemoteException {
+        mDialogSurface.scheduleLayoutSurface(x, y, width, height);
+    }
+
+    @Override
+    public IBinder asBinder() {

[boliu, 2017/01/04 01:48:45]

does returning null here work? won't that break... something? I think you are
supposed to extend IDialogSurface.Stub, then you don't need to worry about this

otoh, does the wrapper need to inherit from aidl interface at all? is anything
calling this object through aidl? because it looks very confusing that a method
is both overriding IInterface (ie it's being called through aidl) and have
@CalledByNative

[liberato (no reviews please), 2017/01/11 22:17:58]

i don't think that returning null here will break anything, since binder never
finds out about this object anyway.

it's not needed to inherit from the aidl interface.  however, i wanted to
enforce that it implements IDialogSurface, and this was the only way to do so
that i could see.  i.e., if this ever diverges from IDialogSurface, then
something's broken.

WDYT?

[boliu, 2017/01/12 20:24:19]

I feel is still leads to too much confusion.

[liberato (no reviews please), 2017/02/03 21:28:32]

per our offline renaming discussion, this won't be an I* anymore.  i just forgot
to update my CL comment before sending.  sorry about that.

+        return null;
+    }
+}