DialogSurfaceManager implementation.

media/base/android/dialog_surface.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_ANDROID_DIALOG_SURFACE_H_
+#define MEDIA_BASE_ANDROID_DIALOG_SURFACE_H_
+
+#include <jni.h>
+#include <stddef.h>
+#include <stdint.h>
+
+#include <set>
+#include <string>
+
+#include "base/android/scoped_java_ref.h"
+#include "base/callback.h"
+#include "base/macros.h"
+#include "base/task_runner.h"
+#include "base/threading/thread_checker.h"
+#include "base/time/time.h"
+#include "media/base/media_export.h"
+#include "ui/gfx/geometry/rect.h"
+#include "ui/gl/android/scoped_java_surface.h"
+
+namespace media {
+
+class DialogSurfaceCallback;
+class DialogSurfaceManager;
+
+// This class implements the C++ wrapper around a java DialogSurface.
+// All callbacks happen on the thread that it's constructed on.
+class MEDIA_EXPORT DialogSurface {

[Tima Vaisburd, 2016/08/03 18:05:13]

A general comment: I like stub CLs because they make it easier to concentrate on
the interface and documentation, but then I'd expect complete and documented
interfaces. Are there going to be more public methods? Why did you choose to
omit them?

In particular, it seems a comment in DialogSurfaceManager suggests
void GetSurface() and void ScheduleLayout(rect) ?

As well, the headers seem not to be used yet. I'd say it would be better to
remove unused headers everywhere and add them in later CLs when they are needed.

[liberato (no reviews please), 2016/08/03 23:11:55]

they're included because some of the internal structs are used. 
DialogSurface::Config, for example, is used by dialog manager.

i agree that it's a little confusing as it is.  i re-added some of the methods
to dialog_surface.h, commented out since there's no impl file yet.

+ public:
+  // These must match DialogSurface.java

[Tima Vaisburd, 2016/08/03 18:05:13]

I could not find DialogSurface.java in this CL. Where is it?

[liberato (no reviews please), 2016/08/03 23:11:54]

intentionally omitted for scope.  i wanted to remove all of dialog_surface.h,
but couldn't do it.

+  enum CallbackOp { SURFACE_CREATED = 0, SURFACE_DESTROYED = 1 };
+
+  // Callback type for finding out about the status of the surface.  While we
+  // don't use this directly, it lets us keep DialogSurfaceCallback as an
+  // implementation detail.
+  using Callback = base::Callback<void(CallbackOp)>;
+
+  // Configuration for the surface.
+  struct Config {
+    gfx::Rect rect;
+    // This may also include pixel format, is_secure, etc.
+  };
+};
+
+}  // namespace media
+
+#endif  // MEDIA_BASE_ANDROID_DIALOG_SURFACE_H_