Add use counter for multiple origins in Timing-Allow-Origin

Add use counter for multiple origins in Timing-Allow-Origin

As part of a discussion about Timing-Allow-Origin and multiple origins in that syntax[1], the possibility of a change to the syntax was raised. In order for that to be considered, we need to check usage.

This CL does that by adding a counter when there's more than 1 origin in that header.

[1] https://github.com/w3c/resource-timing/issues/62
BUG=

Committed: https://crrev.com/b3fc51169fddaddeae171b2cc7f10170706da77c
Cr-Commit-Position: refs/heads/master@{#408877}

[Yoav Weiss, 2016-07-25 15:01:57]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 15:02:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 15:03:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 15:03:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yoav Weiss, 2016-07-25 15:25:03]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 15:25:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 17:29:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 17:29:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yoav Weiss, 2016-07-25 22:22:14]

Description was changed from

==========
Add use counter for multiple origins in Timing-Allow-Origin

BUG=
==========

to

==========
Add use counter for multiple origins in Timing-Allow-Origin

As part of a discussion about Timing-Allow-Origin and multiple origins in that
syntax[1], the possibility of a change to the syntax was raised. In order for
that to be considered, we need to check usage.

This CL does that by adding a counter when there's more than 1 origin in that
header.

[1] https://github.com/w3c/resource-timing/issues/62
BUG=
==========

[Yoav Weiss, 2016-07-25 22:22:14]

yoav@yoav.ws changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-07-27 08:46:10]

https://codereview.chromium.org/2178973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):

https://codereview.chromium.org/2178973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:206:
UseCounter::count(context, UseCounter::MultipleOriginsInTimingAllowOrigin);
It's probably worth adding a counter for single origins as well so that we have
a feel for how often this occurs in the context of the entirety of TAO usage.

https://codereview.chromium.org/2178973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/timing/PerformanceBase.cpp:240: bool
allowTimingDetails = passesTimingAllowCheck(finalResponse, *securityOrigin,
info.originalTimingAllowOrigin(), getExecutionContext());
Nit: This is |context|, right?

[Yoav Weiss, 2016-07-27 11:52:28]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 11:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 11:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 11:54:21]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yoav Weiss, 2016-07-27 11:59:20]

On 2016/07/27 08:46:10, Mike West wrote:
>
https://codereview.chromium.org/2178973002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/timing/PerformanceBase.cpp (right):
> 
>
https://codereview.chromium.org/2178973002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/timing/PerformanceBase.cpp:206:
> UseCounter::count(context, UseCounter::MultipleOriginsInTimingAllowOrigin);
> It's probably worth adding a counter for single origins as well so that we
have
> a feel for how often this occurs in the context of the entirety of TAO usage.

Added counters for single origin as well as "*" TAO value.

> 
>
https://codereview.chromium.org/2178973002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/timing/PerformanceBase.cpp:240: bool
> allowTimingDetails = passesTimingAllowCheck(finalResponse, *securityOrigin,
> info.originalTimingAllowOrigin(), getExecutionContext());
> Nit: This is |context|, right?

Yes it is. I'll change that and rebase when I'm not between flights... (can't
afford a rebuild right now)

[Mike West, 2016-07-28 13:41:43]

LGTM, assuming you rebase and re-run the histograms.xml generator.

https://codereview.chromium.org/2178973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/2178973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1261: 
Nit: No extra whitespace. Also, you'll need to rebase this.

[Yoav Weiss, 2016-07-30 15:21:26]

rebase

[Yoav Weiss, 2016-07-30 15:21:35]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 15:21:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2016-07-30 15:24:23]

On 2016/07/30 15:21:26, Yoav Weiss wrote:
> rebase

Thanks for reviewing! :)

[commit-bot: I haz the power, 2016-07-30 17:03:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 17:03:39]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2016-07-30 21:50:09]

The CQ bit was checked by yoav@yoav.ws

[Yoav Weiss, 2016-07-30 21:50:09]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2178973002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-30 21:50:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 21:53:46]

Description was changed from

==========
Add use counter for multiple origins in Timing-Allow-Origin

As part of a discussion about Timing-Allow-Origin and multiple origins in that
syntax[1], the possibility of a change to the syntax was raised. In order for
that to be considered, we need to check usage.

This CL does that by adding a counter when there's more than 1 origin in that
header.

[1] https://github.com/w3c/resource-timing/issues/62
BUG=
==========

to

==========
Add use counter for multiple origins in Timing-Allow-Origin

As part of a discussion about Timing-Allow-Origin and multiple origins in that
syntax[1], the possibility of a change to the syntax was raised. In order for
that to be considered, we need to check usage.

This CL does that by adding a counter when there's more than 1 origin in that
header.

[1] https://github.com/w3c/resource-timing/issues/62
BUG=
==========

[commit-bot: I haz the power, 2016-07-30 21:53:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-30 21:55:21]

Description was changed from

==========
Add use counter for multiple origins in Timing-Allow-Origin

As part of a discussion about Timing-Allow-Origin and multiple origins in that
syntax[1], the possibility of a change to the syntax was raised. In order for
that to be considered, we need to check usage.

This CL does that by adding a counter when there's more than 1 origin in that
header.

[1] https://github.com/w3c/resource-timing/issues/62
BUG=
==========

to

==========
Add use counter for multiple origins in Timing-Allow-Origin

As part of a discussion about Timing-Allow-Origin and multiple origins in that
syntax[1], the possibility of a change to the syntax was raised. In order for
that to be considered, we need to check usage.

This CL does that by adding a counter when there's more than 1 origin in that
header.

[1] https://github.com/w3c/resource-timing/issues/62
BUG=

Committed: https://crrev.com/b3fc51169fddaddeae171b2cc7f10170706da77c
Cr-Commit-Position: refs/heads/master@{#408877}
==========

[commit-bot: I haz the power, 2016-07-30 21:55:22]

Patchset 4 (id:??) landed as
https://crrev.com/b3fc51169fddaddeae171b2cc7f10170706da77c
Cr-Commit-Position: refs/heads/master@{#408877}