Add webrtc_perf_tests to BUILD.gn

Add webrtc_perf_tests to BUILD.gn

Updated the sources in audio_processing:audioproc_test_utils to match the configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

Removed audio_buffer_tools from modules_unittests to match the gyp file.

BUG=webrtc:6041
Committed: https://crrev.com/529f83c521c6726017bed9da16664063b0041eaf
Cr-Commit-Position: refs/heads/master@{#13541}

[ehmaldonado_webrtc, 2016-07-25 14:54:33]

ehmaldonado@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[ehmaldonado_webrtc, 2016-07-25 14:54:34]

gn gen out/Release
ninja -C out/Release webrtc_perf_tests
out/Release/webrtc_perf_tests

It's still running, it's OK so far.

[ehmaldonado_webrtc, 2016-07-25 15:07:41]

On 2016/07/25 14:54:34, ehmaldonado_webrtc wrote:
> It's still running, it's OK so far.

It's done with all tests passing.

[phoglund_chromium, 2016-07-26 12:33:29]

phoglund@chromium.org changed reviewers:
+ phoglund@chromium.org

[phoglund_chromium, 2016-07-26 12:33:29]

https://codereview.chromium.org/2178963002/diff/1/webrtc/modules/audio_proces...
File webrtc/modules/audio_processing/BUILD.gn (right):

https://codereview.chromium.org/2178963002/diff/1/webrtc/modules/audio_proces...
webrtc/modules/audio_processing/BUILD.gn:322: "test/audio_buffer_tools.cc",
Did you mean to make this change in this cl? If so, please update the CL
description.

[ehmaldonado_webrtc, 2016-07-26 12:43:21]

Description was changed from

==========
Add webrtc_perf_tests to BUILD.gn

BUG=webrtc:6041

GN: Add webrtc_perf_tests.
==========

to

==========
Add webrtc_perf_tests to BUILD.gn

Updated audio_processing:audioproc_test_utils to include
"test/audio_buffer_tools.cc" and "test/audio_buffer_tools.h" as sources.
This is to match the configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

BUG=webrtc:6041

GN: Add webrtc_perf_tests.
==========

[ehmaldonado_webrtc, 2016-07-26 12:44:07]

https://codereview.chromium.org/2178963002/diff/1/webrtc/modules/audio_proces...
File webrtc/modules/audio_processing/BUILD.gn (right):

https://codereview.chromium.org/2178963002/diff/1/webrtc/modules/audio_proces...
webrtc/modules/audio_processing/BUILD.gn:322: "test/audio_buffer_tools.cc",
On 2016/07/26 12:33:29, phoglund_chrome wrote:
> Did you mean to make this change in this cl? If so, please update the CL
> description.

Yes, I meant to change it.
Done.

[phoglund_chromium, 2016-07-26 14:24:23]

lgtm

A few things to think of with cl descriptions: don't describe exactly what you
did, rather why you did it. Also try to keep a 72-char line width (looks better
in the commit message later).

[ehmaldonado_webrtc, 2016-07-26 14:40:23]

Description was changed from

==========
Add webrtc_perf_tests to BUILD.gn

Updated audio_processing:audioproc_test_utils to include
"test/audio_buffer_tools.cc" and "test/audio_buffer_tools.h" as sources.
This is to match the configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

BUG=webrtc:6041

GN: Add webrtc_perf_tests.
==========

to

==========
Add webrtc_perf_tests to BUILD.gn

Updated the sources in audio_processing:audioproc_test_utils.
This is to match the configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

BUG=webrtc:6041

GN: Add webrtc_perf_tests.
==========

[ehmaldonado_webrtc, 2016-07-26 14:40:33]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-07-26 14:40:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-26 14:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 14:43:11]

Try jobs failed on following builders:
  mac_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/4787)

[ehmaldonado_webrtc, 2016-07-27 07:51:43]

Description was changed from

==========
Add webrtc_perf_tests to BUILD.gn

Updated the sources in audio_processing:audioproc_test_utils.
This is to match the configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

BUG=webrtc:6041

GN: Add webrtc_perf_tests.
==========

to

==========
Add webrtc_perf_tests to BUILD.gn

Updated the sources in audio_processing:audioproc_test_utils to match the
configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

Removed audio_buffer_tools from modules_unittests to match the gyp file.

BUG=webrtc:6041
==========

[ehmaldonado_webrtc, 2016-07-27 07:54:40]

On 2016/07/26 14:24:23, phoglund_chrome wrote:
> lgtm
> 
> A few things to think of with cl descriptions: don't describe exactly what you
> did, rather why you did it. Also try to keep a 72-char line width (looks
better
> in the commit message later).

Some trybots failed when trying to build modules_unittests.
I think I've fixed it now. It seems that the problem was a mismatch between the
configuration in modules/BUILD.gn and modules/modules.gyp.

PTAL

[phoglund_chromium, 2016-07-27 08:27:28]

lgtm

[ehmaldonado_webrtc, 2016-07-27 08:44:22]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-07-27 08:44:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[phoglund, 2016-07-27 08:48:07]

phoglund@webrtc.org changed reviewers:
+ henrika@webrtc.org

[phoglund, 2016-07-27 08:48:07]

henrika, please rubberstamp

[commit-bot: I haz the power, 2016-07-27 08:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 08:51:23]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6982)

[ehmaldonado_webrtc, 2016-07-27 14:49:06]

friendly ping

[henrika_webrtc, 2016-07-27 15:08:44]

LGTM

[ehmaldonado_webrtc, 2016-07-27 15:13:07]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-07-27 15:13:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-27 15:14:40]

Description was changed from

==========
Add webrtc_perf_tests to BUILD.gn

Updated the sources in audio_processing:audioproc_test_utils to match the
configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

Removed audio_buffer_tools from modules_unittests to match the gyp file.

BUG=webrtc:6041
==========

to

==========
Add webrtc_perf_tests to BUILD.gn

Updated the sources in audio_processing:audioproc_test_utils to match the
configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

Removed audio_buffer_tools from modules_unittests to match the gyp file.

BUG=webrtc:6041
==========

[commit-bot: I haz the power, 2016-07-27 15:14:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 15:14:52]

Description was changed from

==========
Add webrtc_perf_tests to BUILD.gn

Updated the sources in audio_processing:audioproc_test_utils to match the
configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

Removed audio_buffer_tools from modules_unittests to match the gyp file.

BUG=webrtc:6041
==========

to

==========
Add webrtc_perf_tests to BUILD.gn

Updated the sources in audio_processing:audioproc_test_utils to match the
configuration on
"webrtc/modules/audio_processing/audio_processing_tests.gypi"

Removed audio_buffer_tools from modules_unittests to match the gyp file.

BUG=webrtc:6041

Committed: https://crrev.com/529f83c521c6726017bed9da16664063b0041eaf
Cr-Commit-Position: refs/heads/master@{#13541}
==========

[commit-bot: I haz the power, 2016-07-27 15:14:54]

Patchset 2 (id:??) landed as
https://crrev.com/529f83c521c6726017bed9da16664063b0041eaf
Cr-Commit-Position: refs/heads/master@{#13541}

[henrika_webrtc, 2016-07-27 15:23:22]

But I don't know GN. Hence, please verify with someone who knows those details
(kjellander@).

[ehmaldonado_webrtc, 2016-07-28 07:46:00]

On 2016/07/27 15:23:22, henrika_webrtc wrote:
> But I don't know GN. Hence, please verify with someone who knows those details
> (kjellander@).

Will do.