Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2178943002: [builtins] move remaining builtins into separate files. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] move remaining builtins into separate files. R=bmeurer@chromium.org BUG=v8:5197 Committed: https://crrev.com/a4bd96a6e2f6b0f19f8fd9379ba42bd6e75190be Cr-Commit-Position: refs/heads/master@{#38034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+591 lines, -552 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M src/builtins/builtins.cc View 3 chunks +7 lines, -552 lines 0 comments Download
A src/builtins/builtins-api.cc View 1 chunk +286 lines, -0 lines 0 comments Download
A src/builtins/builtins-call.cc View 1 chunk +151 lines, -0 lines 0 comments Download
M src/builtins/builtins-function.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A src/builtins/builtins-generator.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M src/builtins/builtins-internal.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M src/v8.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 5 months ago (2016-07-25 13:15:22 UTC) #1
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-25 17:51:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178943002/1
4 years, 5 months ago (2016-07-25 18:51:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 19:15:08 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 19:16:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4bd96a6e2f6b0f19f8fd9379ba42bd6e75190be
Cr-Commit-Position: refs/heads/master@{#38034}

Powered by Google App Engine
This is Rietveld 408576698