Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2178913003: Add HardStopGradientBench_ScaleNumHardStops.cpp (Closed)

Created:
4 years, 4 months ago by fmenozzi
Modified:
4 years, 4 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add HardStopGradientBench_ScaleNumHardStops.cpp Rename HardStopGradientBench.cpp to HardStopGradientBench_ScaleNumColors.cpp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178913003 Committed: https://skia.googlesource.com/skia/+/17e829794db9621879baf2e90856a72b17eaf7dc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tom's suggestions #

Total comments: 1

Patch Set 3 : Third time's the charm #

Patch Set 4 : Fix benchmark color/position problems #

Patch Set 5 : Fix off by one error in SkAssert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -124 lines) Patch
D bench/HardStopGradientBench.cpp View 1 chunk +0 lines, -124 lines 0 comments Download
A bench/HardStopGradientBench_ScaleNumColors.cpp View 1 2 3 1 chunk +139 lines, -0 lines 0 comments Download
A bench/HardStopGradientBench_ScaleNumHardStops.cpp View 1 2 3 4 1 chunk +114 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
fmenozzi
Rather than adding to the previous benchmark, I decided to add another and rename the ...
4 years, 4 months ago (2016-07-25 17:13:28 UTC) #3
fmenozzi
bump
4 years, 4 months ago (2016-07-26 12:59:06 UTC) #4
tomhudson
https://codereview.chromium.org/2178913003/diff/1/bench/HardStopGradientBench_ScaleNumColors.cpp File bench/HardStopGradientBench_ScaleNumColors.cpp (right): https://codereview.chromium.org/2178913003/diff/1/bench/HardStopGradientBench_ScaleNumColors.cpp#newcode53 bench/HardStopGradientBench_ScaleNumColors.cpp:53: * trigger the hard stop code. Nit: runon sentence? ...
4 years, 4 months ago (2016-07-26 13:25:14 UTC) #5
fmenozzi
Add Tom's suggestions, ptal
4 years, 4 months ago (2016-07-26 13:32:41 UTC) #6
tomhudson
https://codereview.chromium.org/2178913003/diff/20001/bench/HardStopGradientBench_ScaleNumHardStops.cpp File bench/HardStopGradientBench_ScaleNumHardStops.cpp (right): https://codereview.chromium.org/2178913003/diff/20001/bench/HardStopGradientBench_ScaleNumHardStops.cpp#newcode56 bench/HardStopGradientBench_ScaleNumHardStops.cpp:56: positions[k++] = 0.0f; Setting a 2*k-multiplicity hard stop at ...
4 years, 4 months ago (2016-07-26 13:42:28 UTC) #7
fmenozzi
Third time's the charm, ptal
4 years, 4 months ago (2016-07-26 13:46:50 UTC) #8
tomhudson
lgtm
4 years, 4 months ago (2016-07-26 13:54:27 UTC) #9
fmenozzi
Fixed problems related to color and position distributions in both the benchmarks, ptal
4 years, 4 months ago (2016-07-27 20:40:24 UTC) #10
fmenozzi
bumpity bumpity
4 years, 4 months ago (2016-07-28 14:06:08 UTC) #11
tomhudson
lgtm
4 years, 4 months ago (2016-07-28 15:30:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178913003/60001
4 years, 4 months ago (2016-07-28 15:53:40 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/10141)
4 years, 4 months ago (2016-07-28 16:44:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178913003/80001
4 years, 4 months ago (2016-07-28 16:55:01 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:59:52 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/17e829794db9621879baf2e90856a72b17eaf7dc

Powered by Google App Engine
This is Rietveld 408576698