[telemetry] Handle immediate navigation triggered by tap action

[telemetry] Handle immediate navigation triggered by tap action

This patch modifies telemetry.internal.actions.tap.TapAction to properly
handle the senario where the action leads to an immediate browser
navigation. This is achieved by changing the final JavaScript condition
on which it waits from:

  window.__tapActionDone

to:

  window.__tapActionDone || window.__tapAction === undefined

BUG=chromium:630970, chromium:634343
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a22cce3254f865fa68d04fb2036da157eead368a

[petrcermak, 2016-07-25 11:10:17]

petrcermak@chromium.org changed reviewers:
+ nednguyen@google.com, skyostil@chromium.org

[petrcermak, 2016-07-25 11:10:17]

PTAL.

Thanks,
Petr

[nednguyen, 2016-07-25 11:46:57]

On 2016/07/25 11:10:17, petrcermak wrote:
> PTAL.
> 
> Thanks,
> Petr

lgtm good catch

[petrcermak, 2016-07-25 11:50:07]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-07-25 11:50:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 12:23:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 12:23:11]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[petrcermak, 2016-07-25 15:44:34]

Patchset #3 (id:40001) has been deleted

[petrcermak, 2016-07-25 15:44:43]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-07-25 15:44:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 16:32:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 16:32:25]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[petrcermak, 2016-08-03 14:25:21]

Description was changed from

==========
[telemetry] Handle immediate navigation triggered by tap action

This patch modifies telemetry.internal.actions.tap.TapAction to properly
handle the senario where the action leads to an immediate browser
navigation. This is achieved by changing the final JavaScript condition
on which it waits from:

  window.__tapActionDone

to:

  window.__tapActionDone || window.__tapAction === undefined

BUG=chromium:630970
==========

to

==========
[telemetry] Handle immediate navigation triggered by tap action

This patch modifies telemetry.internal.actions.tap.TapAction to properly
handle the senario where the action leads to an immediate browser
navigation. This is achieved by changing the final JavaScript condition
on which it waits from:

  window.__tapActionDone

to:

  window.__tapActionDone || window.__tapAction === undefined

BUG=chromium:630970
==========

[petrcermak, 2016-08-03 14:25:29]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-03 14:25:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 14:52:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 14:52:06]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[petrcermak, 2016-08-03 15:32:11]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-03 15:32:12]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2178903002/#ps60001
(title: "Enable logging (to figure out why CQ fails)")

[commit-bot: I haz the power, 2016-08-03 15:32:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-08-03 16:17:14]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-03 16:17:15]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2178903002/#ps80001
(title: "Disable sandbox")

[commit-bot: I haz the power, 2016-08-03 16:17:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 16:45:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 16:45:14]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[petrcermak, 2016-08-03 17:03:44]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-03 17:03:45]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2178903002/#ps100001
(title: "Increase logging verbosity")

[commit-bot: I haz the power, 2016-08-03 17:03:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petrcermak, 2016-08-03 17:33:13]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-03 17:33:13]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2178903002/#ps120001
(title: "Log tapping command")

[commit-bot: I haz the power, 2016-08-03 17:33:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 18:09:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 18:09:55]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[petrcermak, 2016-08-03 18:17:47]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-03 18:17:47]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2178903002/#ps140001
(title: "console.log")

[commit-bot: I haz the power, 2016-08-03 18:17:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 18:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 18:48:50]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[petrcermak, 2016-08-04 08:50:13]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-04 08:50:13]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2178903002/#ps160001
(title: "Round coordinates")

[commit-bot: I haz the power, 2016-08-04 08:50:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 09:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 09:02:36]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[petrcermak, 2016-08-04 15:19:06]

Description was changed from

==========
[telemetry] Handle immediate navigation triggered by tap action

This patch modifies telemetry.internal.actions.tap.TapAction to properly
handle the senario where the action leads to an immediate browser
navigation. This is achieved by changing the final JavaScript condition
on which it waits from:

  window.__tapActionDone

to:

  window.__tapActionDone || window.__tapAction === undefined

BUG=chromium:630970
==========

to

==========
[telemetry] Handle immediate navigation triggered by tap action

This patch modifies telemetry.internal.actions.tap.TapAction to properly
handle the senario where the action leads to an immediate browser
navigation. This is achieved by changing the final JavaScript condition
on which it waits from:

  window.__tapActionDone

to:

  window.__tapActionDone || window.__tapAction === undefined

BUG=chromium:630970,chromium:634343
==========

[petrcermak, 2016-08-04 15:19:33]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-04 15:19:33]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2178903002/#ps90003
(title: "Disable tests on Windows")

[commit-bot: I haz the power, 2016-08-04 15:19:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 15:50:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 15:50:02]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[petrcermak, 2016-08-04 16:04:32]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-04 16:04:32]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2178903002/#ps190001
(title: "s/windows/win/g")

[commit-bot: I haz the power, 2016-08-04 16:04:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 17:08:33]

Description was changed from

==========
[telemetry] Handle immediate navigation triggered by tap action

This patch modifies telemetry.internal.actions.tap.TapAction to properly
handle the senario where the action leads to an immediate browser
navigation. This is achieved by changing the final JavaScript condition
on which it waits from:

  window.__tapActionDone

to:

  window.__tapActionDone || window.__tapAction === undefined

BUG=chromium:630970,chromium:634343
==========

to

==========
[telemetry] Handle immediate navigation triggered by tap action

This patch modifies telemetry.internal.actions.tap.TapAction to properly
handle the senario where the action leads to an immediate browser
navigation. This is achieved by changing the final JavaScript condition
on which it waits from:

  window.__tapActionDone

to:

  window.__tapActionDone || window.__tapAction === undefined

BUG=chromium:630970,chromium:634343

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-08-04 17:08:34]

Committed patchset #10 (id:190001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...