Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2178863002: Convert editing/insert-div-22.html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/insert-div-22.html to use w3c test harness This patch converts "editing/insert-div-22.html" to use w3c test harness to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/ba49be21047c327c3e82292cc8991b8668d99994 Cr-Commit-Position: refs/heads/master@{#407670}

Patch Set 1 : 2016-07-25T16:20:31 #

Total comments: 2

Patch Set 2 : 2016-07-25T17:34:19 #

Messages

Total messages: 19 (12 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-25 07:43:47 UTC) #5
Xiaocheng
https://codereview.chromium.org/2178863002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert-div-022.html File third_party/WebKit/LayoutTests/editing/inserting/insert-div-022.html (right): https://codereview.chromium.org/2178863002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert-div-022.html#newcode19 third_party/WebKit/LayoutTests/editing/inserting/insert-div-022.html:19: '<p id="test"><b>|<br></b>bar</p>', I thought there should be an 'x' ...
4 years, 5 months ago (2016-07-25 08:04:18 UTC) #6
yosin_UTC9
PTAL PS#1 does execCommand("insertType", false, "x") instead of executing "insertText"... :-< https://codereview.chromium.org/2178863002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/insert-div-022.html File third_party/WebKit/LayoutTests/editing/inserting/insert-div-022.html (right): ...
4 years, 5 months ago (2016-07-25 08:36:01 UTC) #11
Xiaocheng
lgtm
4 years, 5 months ago (2016-07-25 09:25:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178863002/20001
4 years, 4 months ago (2016-07-26 01:15:40 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 01:19:41 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 01:22:29 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba49be21047c327c3e82292cc8991b8668d99994
Cr-Commit-Position: refs/heads/master@{#407670}

Powered by Google App Engine
This is Rietveld 408576698