chrome/browser/installable/installable_logging.cc - Issue 2178833002: Add new app banner metrics using InstallableStatusCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/installable/installable_logging.cc

Issue 2178833002: Add new app banner metrics using InstallableStatusCode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-integrate-checker-no-refptr

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/installable/installable_logging.h ('K') | « chrome/browser/installable/installable_logging.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/installable/installable_logging.cc

diff --git a/chrome/browser/installable/installable_logging.cc b/chrome/browser/installable/installable_logging.cc

index 77ec9916c1dfdb4a2a0561277b810c820466d38c..238024f5b1e0c5c08285ecd5e5a6aeaadc1fbd9f 100644

--- a/chrome/browser/installable/installable_logging.cc

+++ b/chrome/browser/installable/installable_logging.cc

@@ -72,6 +72,15 @@ void LogErrorToConsole(content::WebContents* web_contents,

const char* pattern = nullptr;

switch (code) {

case NO_ERROR_DETECTED:

+ // These codes are solely used for UMA reporting.

+ case ALREADY_INSTALLED:

+ case INSUFFICIENT_ENGAGEMENT:

+ case PACKAGE_NAME_OR_START_URL_EMPTY:

+ case PREVIOUSLY_BLOCKED:

+ case PREVIOUSLY_IGNORED:

+ case SHOWING_NATIVE_APP_BANNER:

+ case SHOWING_WEB_APP_BANNER:

+ case FAILED_TO_CREATE_BANNER:

case MAX_ERROR_CODE:

return;

case RENDERER_EXITING: