Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2815)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2178833002: Add new app banner metrics using InstallableStatusCode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-integrate-checker-no-refptr
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index a0456b2d6bd4bc4bac4ef582710e1c24332d843e..df7b3fc0edc3166632c0810075801ebc9a02be04 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -186,6 +186,9 @@ void AppBannerManagerAndroid::ShowBanner() {
if (infobar) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);
+ TrackInstallableErrorCode(SHOWING_WEB_APP_BANNER);
+ } else {
+ TrackInstallableErrorCode(FAILED_TO_CREATE_BANNER);
}
} else {
std::unique_ptr<AppBannerInfoBarDelegateAndroid> delegate(
@@ -197,6 +200,9 @@ void AppBannerManagerAndroid::ShowBanner() {
if (infobar) {
RecordDidShowBanner("AppBanner.NativeApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_NATIVE_APP_BANNER_CREATED);
+ TrackInstallableErrorCode(SHOWING_NATIVE_APP_BANNER);
+ } else {
+ TrackInstallableErrorCode(FAILED_TO_CREATE_BANNER);
}
}
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.cc » ('j') | chrome/browser/banners/app_banner_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698