Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2481)

Unified Diff: chrome/browser/banners/app_banner_settings_helper.h

Issue 2178833002: Add new app banner metrics using InstallableStatusCode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-integrate-checker-no-refptr
Patch Set: Fix histogram name Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_metrics.cc ('k') | chrome/browser/banners/app_banner_settings_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_settings_helper.h
diff --git a/chrome/browser/banners/app_banner_settings_helper.h b/chrome/browser/banners/app_banner_settings_helper.h
index 9ba0214051728ad1e9c88dd98d6fc401efcf729a..22499d717c7caa8aed4ab9864b4e40047a8b9772 100644
--- a/chrome/browser/banners/app_banner_settings_helper.h
+++ b/chrome/browser/banners/app_banner_settings_helper.h
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "base/time/time.h"
+#include "chrome/browser/installable/installable_logging.h"
#include "ui/base/page_transition_types.h"
namespace content {
@@ -95,11 +96,13 @@ class AppBannerSettingsHelper {
ui::PageTransition transition_type);
// Determine if the banner should be shown, given the recorded events for the
- // supplied app.
- static bool ShouldShowBanner(content::WebContents* web_contents,
- const GURL& origin_url,
- const std::string& package_name_or_start_url,
- base::Time time);
+ // supplied app. Returns an InstallableStatusCode indicated the reason why the
+ // banner shouldn't be shown, or NO_ERROR_DETECTED if it should be shown.
+ static InstallableStatusCode ShouldShowBanner(
+ content::WebContents* web_contents,
+ const GURL& origin_url,
+ const std::string& package_name_or_start_url,
+ base::Time time);
// Gets the could have been shown events that are stored for the given package
// or start url. This is only exposed for testing.
« no previous file with comments | « chrome/browser/banners/app_banner_metrics.cc ('k') | chrome/browser/banners/app_banner_settings_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698