chrome/browser/banners/app_banner_manager_desktop.cc - Issue 2178833002: Add new app banner metrics using InstallableStatusCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_manager_desktop.cc

Issue 2178833002: Add new app banner metrics using InstallableStatusCode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-integrate-checker-no-refptr

Patch Set: Fix histogram name Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/banners/app_banner_manager_desktop.cc

diff --git a/chrome/browser/banners/app_banner_manager_desktop.cc b/chrome/browser/banners/app_banner_manager_desktop.cc

index bab306a008fff7ea2c58aaaa8f24208b802e2206..710f25c65e781231d30c0258cdbacca073f2d926 100644

--- a/chrome/browser/banners/app_banner_manager_desktop.cc

+++ b/chrome/browser/banners/app_banner_manager_desktop.cc

@@ -89,6 +89,9 @@ void AppBannerManagerDesktop::ShowBanner() {

if (infobar) {

RecordDidShowBanner("AppBanner.WebApp.Shown");

TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);

+ ReportStatus(contents, SHOWING_WEB_APP_BANNER);

+ } else {

+ ReportStatus(contents, FAILED_TO_CREATE_BANNER);

}

« no previous file with comments | « chrome/browser/banners/app_banner_manager_browsertest.cc ('k') | chrome/browser/banners/app_banner_metrics.h » ('j') | no next file with comments »