Chromium Code Reviews| Index: chrome/browser/banners/app_banner_metrics.cc |
| diff --git a/chrome/browser/banners/app_banner_metrics.cc b/chrome/browser/banners/app_banner_metrics.cc |
| index 58e373d3b90f8786c20a60c933a28dcd343ea6f0..c5321f56e91127522d94ce62eb58a90c15431536 100644 |
| --- a/chrome/browser/banners/app_banner_metrics.cc |
| +++ b/chrome/browser/banners/app_banner_metrics.cc |
| @@ -6,6 +6,7 @@ |
| #include "base/metrics/histogram_macros.h" |
| #include "base/metrics/sparse_histogram.h" |
| +#include "chrome/browser/installable/installable_logging.h" |
| namespace banners { |
| @@ -16,6 +17,8 @@ const char kMinutesHistogram[] = |
| "AppBanners.MinutesFromFirstVisitToBannerShown"; |
| const char kUserResponseHistogram[] = "AppBanners.UserResponse"; |
| const char kBeforeInstallEventHistogram[] = "AppBanners.BeforeInstallEvent"; |
| +const char kInstallableStatusCodeHistogram[] = |
| + "AppBanners.InstallableStatusCode"; |
|
Ilya Sherman
2016/08/15 22:02:20
nit: This doesn't match the name in histograms.xml
dominickn
2016/08/16 00:30:43
Whoops, done.
|
| void TrackDismissEvent(int event) { |
| DCHECK_LT(DISMISS_EVENT_MIN, event); |
| @@ -55,4 +58,10 @@ void TrackBeforeInstallEvent(int event) { |
| UMA_HISTOGRAM_SPARSE_SLOWLY(kBeforeInstallEventHistogram, event); |
| } |
| +void TrackInstallableStatusCode(InstallableStatusCode code) { |
| + DCHECK_LE(NO_ERROR_DETECTED, code); |
| + DCHECK_LT(code, MAX_ERROR_CODE); |
| + UMA_HISTOGRAM_SPARSE_SLOWLY(kInstallableStatusCodeHistogram, code); |
| +} |
| + |
| } // namespace banners |