Add new app banner metrics using InstallableStatusCode.

chrome/browser/installable/installable_logging.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/installable/installable_logging.h"
 
 #include "base/macros.h"
 #include "base/strings/stringprintf.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 
 namespace {
 
 const std::string& GetMessagePrefix() {
   CR_DEFINE_STATIC_LOCAL(std::string, message_prefix,
                          ("Site cannot be installed: "));
   return message_prefix;
 }
 
-// Error message strings corresponding to the InstallableErrorCode enum.
+// Error message strings corresponding to the InstallableStatusCode enum.
 static const char kRendererExitingMessage[] =
     "the page is in the process of being closed";
 static const char kRendererCancelledMessage[] =
     "the page has requested the banner prompt be cancelled";
 static const char kUserNavigatedMessage[] =
     "the page was navigated before the banner could be shown";
 static const char kNotInMainFrameMessage[] =
     "the page is not loaded in the main frame";
 static const char kNotFromSecureOriginMessage[] =
     "the page is not served from a secure origin";
@@ skipping 25 matching lines @@
     "the specified application platform is not supported on Android";
 static const char kNoIdSpecifiedMessage[] =
     "no Play store ID provided";
 static const char kIdsDoNotMatchMessage[] =
     "a Play Store app URL and Play Store ID were specified in the manifest, "
     "but they do not match";
 
 }  // namespace
 
 void LogErrorToConsole(content::WebContents* web_contents,
-                       InstallableErrorCode code,
+                       InstallableStatusCode code,
                        const std::string& param) {
   if (!web_contents)
     return;
 
   content::ConsoleMessageLevel severity = content::CONSOLE_MESSAGE_LEVEL_ERROR;
   const char* pattern = nullptr;
   switch (code) {
     case NO_ERROR_DETECTED:
+    // These codes are solely used for UMA reporting.
+    case ALREADY_INSTALLED:
+    case INSUFFICIENT_ENGAGEMENT:
+    case PACKAGE_NAME_OR_START_URL_EMPTY:
+    case PREVIOUSLY_BLOCKED:
+    case PREVIOUSLY_IGNORED:
+    case SHOWING_NATIVE_APP_BANNER:
+    case SHOWING_WEB_APP_BANNER:
+    case FAILED_TO_CREATE_BANNER:
     case MAX_ERROR_CODE:
       return;
     case RENDERER_EXITING:
       pattern = kRendererExitingMessage;
       break;
     case RENDERER_CANCELLED:
       pattern = kRendererCancelledMessage;
       severity = content::CONSOLE_MESSAGE_LEVEL_LOG;
       break;
     case USER_NAVIGATED:
@@ skipping 48 matching lines @@
       break;
   }
 
   if (!pattern)
     return;
   std::string message = param.empty() ?
       pattern : base::StringPrintf(pattern, param.c_str());
   web_contents->GetMainFrame()->AddMessageToConsole(
       severity, GetMessagePrefix() + message);
 }