Add new app banner metrics using InstallableStatusCode.

chrome/browser/banners/app_banner_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 #define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 85 matching lines @@
 
   // Return a string identifying this app for metrics.
   virtual std::string GetAppIdentifier();
 
   // Return a string describing what type of banner is being created. Used when
   // alerting websites that a banner is about to be created.
   virtual std::string GetBannerType();
 
   // Returns a string parameter for a devtools console message corresponding to
   // |code|. Returns the empty string if |code| requires no parameter.
-  std::string GetErrorParam(InstallableErrorCode code);
+  std::string GetStatusParam(InstallableStatusCode code);
 
   // Returns the ideal and minimum icon sizes required for being installable.
   virtual int GetIdealIconSizeInDp();
   virtual int GetMinimumIconSizeInDp();
 
   // Returns a WeakPtr to this object. Exposed so subclasses/infobars may
   // may bind callbacks without needing their own WeakPtrFactory.
   base::WeakPtr<AppBannerManager> GetWeakPtr();
 
   // Returns true if |is_debug_mode_| is true or the
   // kBypassAppBannerEngagementChecks flag is set.
-  bool IsDebugMode() const;
+  virtual bool IsDebugMode() const;
 
   // Returns true if the webapp at |start_url| has already been installed.
   virtual bool IsWebAppInstalled(content::BrowserContext* browser_context,
                                  const GURL& start_url);
 
   // Callback invoked by the InstallableManager once it has fetched the page's
   // manifest.
   void OnDidGetManifest(const InstallableData& result);
 
   // Run at the conclusion of OnDidGetManifest. For web app banners, this calls
   // back to the InstallableManager to continue checking criteria. For native
   // app banners, this checks whether native apps are preferred in the manifest,
   // and calls to Java to verify native app details. If a native banner isn't or
   // can't be requested, it continues with the web app banner checks.
   virtual void PerformInstallableCheck();
 
   // Callback invoked by the InstallableManager once it has finished checking
   // all other installable properties.
   void OnDidPerformInstallableCheck(const InstallableData& result);
 
   // Records that a banner was shown. The |event_name| corresponds to the RAPPOR
   // metric being recorded.
   void RecordDidShowBanner(const std::string& event_name);
 
   // Logs an error message corresponding to |code| to the devtools console
   // attached to |web_contents|. Does nothing if IsDebugMode() returns false.
-  void ReportError(content::WebContents* web_contents,
-                   InstallableErrorCode code);
+  void ReportStatus(content::WebContents* web_contents,
+                    InstallableStatusCode code);
 
-  // Stops the banner pipeline. Any callback currently running will terminate
-  // the next time they check |is_active_|.
+  // Stops the banner pipeline, preventing any outstanding callbacks from
+  // running and resetting the manager state. This method is virtual to allow
+  // tests to intercept it and verify correct behaviour.
   virtual void Stop();
 
   // Sends a message to the renderer that the page has met the requirements to
   // show a banner. The page can respond to cancel the banner (and possibly
   // display it later), or otherwise allow it to be shown. This is virtual to
   // allow tests to mock out the renderer IPC.
   virtual void SendBannerPromptRequest();
 
   // content::WebContentsObserver overrides.
   void DidStartNavigation(content::NavigationHandle* handle) override;
@@ skipping 91 matching lines @@
   bool load_finished_;
 
   // Record whether the page decides to defer showing the banner, and if it
   // requests for it to be shown later on.
   bool was_canceled_by_page_;
   bool page_requested_prompt_;
 
   // Whether we should be logging errors to the console for this request.
   bool is_debug_mode_;
 
+  // Whether the installable status has been logged for this run.
+  bool need_to_log_status_;
+
   // The concrete subclasses of this class are expected to have their lifetimes
   // scoped to the WebContents which they are observing. This allows us to use
   // weak pointers for callbacks.
   base::WeakPtrFactory<AppBannerManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerManager);
 };
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_