[Signin] Factor out a helper class to load a continue URL once Sync is configured.

chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_io_data.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/chrome_signin_client.h"
 #include "chrome/browser/signin/chrome_signin_client_factory.h"
 #include "chrome/browser/signin/fake_profile_oauth2_token_service.h"
 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"
 #include "chrome/browser/signin/fake_signin_manager.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_names_io_thread.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
-#include "chrome/browser/sync/profile_sync_service_mock.h"
 #include "chrome/browser/sync/test_profile_sync_service.h"
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_pref_service_syncable.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "components/sync_driver/pref_names.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/test/mock_render_process_host.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
+#include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using ::testing::_;
 using ::testing::AtLeast;
 using ::testing::Return;
 
 namespace {
 
 // Used to confirm OneClickSigninHelper does not trigger redirect when there is
@@ skipping 102 matching lines @@
   }
 };
 
 class TestURLRequest : public base::SupportsUserData {
 public:
   TestURLRequest() {}
   virtual ~TestURLRequest() {}
 };
 
 class OneClickTestProfileSyncService : public TestProfileSyncService {
-  public:
-   virtual ~OneClickTestProfileSyncService() {}
+ public:
+  virtual ~OneClickTestProfileSyncService() {}
 
-   // Helper routine to be used in conjunction with
-   // BrowserContextKeyedServiceFactory::SetTestingFactory().
-   static KeyedService* Build(content::BrowserContext* profile) {
-     return new OneClickTestProfileSyncService(static_cast<Profile*>(profile));
-   }
+  // Helper routine to be used in conjunction with
+  // BrowserContextKeyedServiceFactory::SetTestingFactory().
+  static KeyedService* Build(content::BrowserContext* profile) {
+    return new OneClickTestProfileSyncService(static_cast<Profile*>(profile));
+  }
 
-   // Need to control this for certain tests.
-   virtual bool FirstSetupInProgress() const OVERRIDE {
-     return first_setup_in_progress_;
-   }
+  // Need to control this for certain tests.
+  virtual bool FirstSetupInProgress() const OVERRIDE {
+    return first_setup_in_progress_;
+  }
 
-   // Controls return value of FirstSetupInProgress. Because some bits
-   // of UI depend on that value, it's useful to control it separately
-   // from the internal work and components that are triggered (such as
-   // ReconfigureDataTypeManager) to facilitate unit tests.
-   void set_first_setup_in_progress(bool in_progress) {
-     first_setup_in_progress_ = in_progress;
-   }
+  virtual bool sync_initialized() const OVERRIDE { return sync_initialized_; }
 
-  private:
-   explicit OneClickTestProfileSyncService(Profile* profile)
-       : TestProfileSyncService(
-         NULL,
-         profile,
-         SigninManagerFactory::GetForProfile(profile),
-         ProfileOAuth2TokenServiceFactory::GetForProfile(profile),
-         browser_sync::MANUAL_START),
-         first_setup_in_progress_(false) {}
+  // Controls return value of FirstSetupInProgress. Because some bits
+  // of UI depend on that value, it's useful to control it separately
+  // from the internal work and components that are triggered (such as
+  // ReconfigureDataTypeManager) to facilitate unit tests.
+  void set_first_setup_in_progress(bool in_progress) {
+    first_setup_in_progress_ = in_progress;
+  }
 
-   bool first_setup_in_progress_;
+  void set_sync_initialized(bool initialized) {
+    sync_initialized_ = initialized;
+  }
+
+ private:
+  explicit OneClickTestProfileSyncService(Profile* profile)
+      : TestProfileSyncService(
+          NULL,
+          profile,
+          SigninManagerFactory::GetForProfile(profile),
+          ProfileOAuth2TokenServiceFactory::GetForProfile(profile),
+          browser_sync::MANUAL_START),
+        first_setup_in_progress_(false),
+        sync_initialized_(false) {}
+
+  bool first_setup_in_progress_;
+  bool sync_initialized_;
 };
 
 }  // namespace
 
 class OneClickSigninHelperTest : public ChromeRenderViewHostTestHarness {
  public:
   OneClickSigninHelperTest();
 
   virtual void SetUp() OVERRIDE;
   virtual void TearDown() OVERRIDE;
 
   // Sets up the sign-in manager for tests.  If |username| is
   // is not empty, the profile of the mock WebContents will be connected to
   // the given account.
   void SetUpSigninManager(const std::string& username);
 
   // Set the ID of the signin process that the test will assume to be the
   // only process allowed to sign the user in to Chrome.
   void SetTrustedSigninProcessID(int id);
 
   void AddEmailToOneClickRejectedList(const std::string& email);
   void EnableOneClick(bool enable);
   void AllowSigninCookies(bool enable);
   void SetAllowedUsernamePattern(const std::string& pattern);
-  ProfileSyncServiceMock* CreateProfileSyncServiceMock();
   void SubmitGAIAPassword(OneClickSigninHelper* helper);
 
   SigninManagerMock* signin_manager_;
   FakeProfileOAuth2TokenService* fake_oauth2_token_service_;
 
  protected:
   GoogleServiceAuthError no_error_;
 
  private:
   // ChromeRenderViewHostTestHarness overrides:
@@ skipping 62 matching lines @@
   cookie_settings->SetDefaultCookieSetting(enable ? CONTENT_SETTING_ALLOW
                                                   : CONTENT_SETTING_BLOCK);
 }
 
 void OneClickSigninHelperTest::SetAllowedUsernamePattern(
     const std::string& pattern) {
   PrefService* local_state = g_browser_process->local_state();
   local_state->SetString(prefs::kGoogleServicesUsernamePattern, pattern);
 }
 
-ProfileSyncServiceMock*
-OneClickSigninHelperTest::CreateProfileSyncServiceMock() {
-  ProfileSyncServiceMock* sync_service = static_cast<ProfileSyncServiceMock*>(
-      ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
-          profile(),
-          ProfileSyncServiceMock::BuildMockProfileSyncService));
-  EXPECT_CALL(*sync_service, FirstSetupInProgress()).WillRepeatedly(
-      Return(false));
-  EXPECT_CALL(*sync_service, sync_initialized()).WillRepeatedly(Return(true));
-  EXPECT_CALL(*sync_service, GetAuthError()).
-      WillRepeatedly(::testing::ReturnRef(no_error_));
-  EXPECT_CALL(*sync_service, sync_initialized()).WillRepeatedly(Return(false));
-  ON_CALL(*sync_service, GetRegisteredDataTypes())
-      .WillByDefault(Return(syncer::ModelTypeSet()));
-  sync_service->Initialize();
-  return sync_service;
-}
-
 void OneClickSigninHelperTest::SubmitGAIAPassword(
     OneClickSigninHelper* helper) {
   autofill::PasswordForm password_form;
   password_form.origin = GURL("https://accounts.google.com");
   password_form.signon_realm = "https://accounts.google.com";
   password_form.password_value = base::UTF8ToUTF16("password");
   helper->PasswordSubmitted(password_form);
 }
 
 content::BrowserContext* OneClickSigninHelperTest::CreateBrowserContext() {
@@ skipping 124 matching lines @@
 TEST_F(OneClickSigninHelperTest, CanOfferFirstSetup) {
   SetUpSigninManager(std::string());
 
   EXPECT_CALL(*signin_manager_, IsAllowedUsername(_)).
         WillRepeatedly(Return(true));
 
   // Invoke OneClickTestProfileSyncService factory function and grab result.
   OneClickTestProfileSyncService* sync =
       static_cast<OneClickTestProfileSyncService*>(
           ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
-              static_cast<Profile*>(browser_context()),
-              OneClickTestProfileSyncService::Build));
+              profile(), OneClickTestProfileSyncService::Build));
+  sync->set_sync_initialized(false);
   sync->Initialize();
+  sync->set_sync_initialized(true);
   sync->set_first_setup_in_progress(true);
 
   EXPECT_TRUE(OneClickSigninHelper::CanOffer(
       web_contents(),
       OneClickSigninHelper::CAN_OFFER_FOR_ALL,
       "foo@gmail.com", NULL));
   EXPECT_TRUE(OneClickSigninHelper::CanOffer(
       web_contents(),
       OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
       "foo@gmail.com", NULL));
@@ skipping 189 matching lines @@
 }
 
 // If Chrome signin is triggered from a webstore install, and user chooses to
 // config sync, then Chrome should redirect immediately to sync settings page,
 // and upon successful setup, redirect back to webstore.
 TEST_F(OneClickSigninHelperTest, SigninFromWebstoreWithConfigSyncfirst) {
   SetUpSigninManager(std::string());
   EXPECT_CALL(*signin_manager_, IsAllowedUsername(_))
       .WillRepeatedly(Return(true));
 
-  ProfileSyncServiceMock* sync_service = CreateProfileSyncServiceMock();
-  EXPECT_CALL(*sync_service, AddObserver(_)).Times(AtLeast(1));
-  EXPECT_CALL(*sync_service, RemoveObserver(_)).Times(AtLeast(1));
-  EXPECT_CALL(*sync_service, sync_initialized()).WillRepeatedly(Return(true));
+  OneClickTestProfileSyncService* sync_service =
+      static_cast<OneClickTestProfileSyncService*>(
+          ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
+              profile(), OneClickTestProfileSyncService::Build));
+  sync_service->set_sync_initialized(true);
 
   content::WebContents* contents = web_contents();
 
   OneClickSigninHelper::CreateForWebContentsWithPasswordManager(contents, NULL);
   OneClickSigninHelper* helper =
       OneClickSigninHelper::FromWebContents(contents);
   helper->SetDoNotClearPendingEmailForTesting();
   helper->set_do_not_start_sync_for_testing();
 
   GURL continueUrl("https://chrome.google.com/webstore?source=5");
   OneClickSigninHelper::ShowInfoBarUIThread(
       "session_index", "user@gmail.com",
       OneClickSigninHelper::AUTO_ACCEPT_EXPLICIT,
       signin::SOURCE_WEBSTORE_INSTALL,
       continueUrl, process()->GetID(), rvh()->GetRoutingID());
 
   SubmitGAIAPassword(helper);
 
   NavigateAndCommit(GURL("https://chrome.google.com/webstore?source=3"));
   helper->DidStopLoading(rvh());
-  helper->OnStateChanged();
-  EXPECT_EQ(GURL(continueUrl), contents->GetURL());
+  sync_service->NotifyObservers();
+  EXPECT_EQ(GURL(continueUrl), contents->GetVisibleURL());
 }
 
 // Checks that the state of OneClickSigninHelper is cleaned when there is a
 // navigation away from the sign in flow that is not triggered by the
 // web contents.
 TEST_F(OneClickSigninHelperTest, CleanTransientStateOnNavigate) {
   content::WebContents* contents = web_contents();
 
   OneClickSigninHelper::CreateForWebContentsWithPasswordManager(contents, NULL);
   OneClickSigninHelper* helper =
       OneClickSigninHelper::FromWebContents(contents);
   helper->SetDoNotClearPendingEmailForTesting();
   helper->auto_accept_ = OneClickSigninHelper::AUTO_ACCEPT_EXPLICIT;
 
   content::LoadCommittedDetails details;
   content::FrameNavigateParams params;
   params.url = GURL("http://crbug.com");
   params.transition = content::PAGE_TRANSITION_TYPED;
   helper->DidNavigateMainFrame(details, params);
 
   EXPECT_EQ(OneClickSigninHelper::AUTO_ACCEPT_NONE, helper->auto_accept_);
 }
 
-// Checks that OneClickSigninHelper doesn't stay an observer of the profile
-// sync service after it's deleted.
-TEST_F(OneClickSigninHelperTest, RemoveObserverFromProfileSyncService) {
-  content::WebContents* contents = web_contents();
-
-  ProfileSyncServiceMock* sync_service = CreateProfileSyncServiceMock();
-
-  OneClickSigninHelper::CreateForWebContentsWithPasswordManager(contents, NULL);
-  OneClickSigninHelper* helper =
-      OneClickSigninHelper::FromWebContents(contents);
-  helper->SetDoNotClearPendingEmailForTesting();
-
-  // Need to expect two calls, because sync service also tears down observers.
-  // TODO(signin): gmock probably isn't the best solution here.
-  EXPECT_CALL(*sync_service, RemoveObserver(_));
-  EXPECT_CALL(*sync_service, RemoveObserver(helper));
-  SetContents(NULL);
-}
-
 TEST_F(OneClickSigninHelperTest, NoRedirectToNTPWithPendingEntry) {
   content::NavigationController& controller = web_contents()->GetController();
   EXPECT_FALSE(controller.GetPendingEntry());
 
   const GURL fooWebUIURL("chrome://foo");
   controller.LoadURL(fooWebUIURL, content::Referrer(),
                      content::PAGE_TRANSITION_TYPED, std::string());
   EXPECT_EQ(fooWebUIURL, controller.GetPendingEntry()->GetURL());
 
   MockWebContentsDelegate delegate;
@@ skipping 274 matching lines @@
   args.email = "foo@gmail.com";
   args.profile = profile();
   MockStarterWrapper* wrapper = new MockStarterWrapper(
       args, OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
   SetCookie("LSID=1234; domain=google.com; secure; httponly");
 
   EXPECT_CALL(*wrapper, DisplayErrorBubble(_));
   wrapper->Start();
   base::RunLoop().RunUntilIdle();
 }