Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2178813002: Add missing resource to non-vulcanized Downloads (Closed)

Created:
4 years, 5 months ago by michaelpg
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing resource to non-vulcanized Downloads BUG=611542 R=dbeam@chromium.org Committed: https://crrev.com/2edcb8d51c07ba717343849fd943cb197dc53f80 Cr-Commit-Position: refs/heads/master@{#407747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
michaelpg
found while testing non-vulcanized Downloads for Polymer 1.6 regressions
4 years, 5 months ago (2016-07-23 23:57:48 UTC) #1
Dan Beam
lgtm
4 years, 5 months ago (2016-07-25 20:54:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178813002/1
4 years, 5 months ago (2016-07-26 03:49:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/250816)
4 years, 5 months ago (2016-07-26 05:04:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178813002/1
4 years, 5 months ago (2016-07-26 07:59:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 09:20:30 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 09:22:35 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2edcb8d51c07ba717343849fd943cb197dc53f80
Cr-Commit-Position: refs/heads/master@{#407747}

Powered by Google App Engine
This is Rietveld 408576698