chrome/browser/task_management/sampling/task_manager_impl.cc - Issue 2178733002: Task manager should support Idle Wakeups on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/sampling/task_manager_impl.cc

Issue 2178733002: Task manager should support Idle Wakeups on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed build error on win_clang Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_management/sampling/task_manager_impl.h ('k') | chrome/browser/task_management/task_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/sampling/task_manager_impl.cc

diff --git a/chrome/browser/task_management/sampling/task_manager_impl.cc b/chrome/browser/task_management/sampling/task_manager_impl.cc

index 4d44f14d8011563e8892e2e7e96588e95b25ea08..de495dbeabd51905211424044ce65fae09f10b2f 100644

--- a/chrome/browser/task_management/sampling/task_manager_impl.cc

+++ b/chrome/browser/task_management/sampling/task_manager_impl.cc

@@ -16,6 +16,7 @@

#include "chrome/browser/task_management/providers/browser_process_task_provider.h"

#include "chrome/browser/task_management/providers/child_process_task_provider.h"

#include "chrome/browser/task_management/providers/web_contents/web_contents_task_provider.h"

+#include "chrome/browser/task_management/sampling/shared_sampler.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/gpu_data_manager.h"

#include "content/public/browser/render_frame_host.h"

@@ -44,10 +45,11 @@ base::LazyInstance<TaskManagerImpl> lazy_task_manager_instance =

} // namespace

TaskManagerImpl::TaskManagerImpl()

- : on_background_data_ready_callback_(base::Bind(

- &TaskManagerImpl::OnTaskGroupBackgroundCalculationsDone,

- base::Unretained(this))),

+ : on_background_data_ready_callback_(

+ base::Bind(&TaskManagerImpl::OnTaskGroupBackgroundCalculationsDone,

+ base::Unretained(this))),

blocking_pool_runner_(GetBlockingPoolRunner()),

+ shared_sampler_(new SharedSampler(blocking_pool_runner_)),

is_running_(false) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

@@ -384,7 +386,7 @@ void TaskManagerImpl::TaskAdded(Task* task) {

if (!task_group)

task_group.reset(new TaskGroup(task->process_handle(), proc_id,

on_background_data_ready_callback_,

- blocking_pool_runner_));

+ shared_sampler_, blocking_pool_runner_));

task_group->AddTask(task);