chrome/browser/ui/task_manager/task_manager_columns.cc - Issue 2178733002: Task manager should support Idle Wakeups on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/task_manager/task_manager_columns.cc

Issue 2178733002: Task manager should support Idle Wakeups on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handling missing results in OnRefreshDone. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_management/task_manager_browsertest_util.cc ('K') | « chrome/browser/task_manager/legacy_task_manager_tester.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/task_manager/task_manager_columns.cc

diff --git a/chrome/browser/ui/task_manager/task_manager_columns.cc b/chrome/browser/ui/task_manager/task_manager_columns.cc

index 008d402a83c2c70ae9c2952291fbf0521ca66a14..70977eac29b4f844a103753a3c80873b0074fcd4 100644

--- a/chrome/browser/ui/task_manager/task_manager_columns.cc

+++ b/chrome/browser/ui/task_manager/task_manager_columns.cc

@@ -71,13 +71,8 @@ const TableColumnData kColumns[] = {

{ IDS_TASK_MANAGER_JAVASCRIPT_MEMORY_ALLOCATED_COLUMN, ui::TableColumn::RIGHT,

-1, 0, arraysize("2000.0K (2000.0 live)") * kCharWidth, -1, true, false,

false },

-#if defined(OS_MACOSX) || defined(OS_LINUX)

- // TODO(port): Port the idle wakeups per second to platforms other than Linux

- // and MacOS (http://crbug.com/120488).

brucedawson 2016/08/03 00:36:55 I think the #if needs to be retained, just modifie

stanisc 2016/08/03 01:39:43 Initially I retained this #if but Nick commented t

{ IDS_TASK_MANAGER_IDLE_WAKEUPS_COLUMN, ui::TableColumn::RIGHT, -1, 0,

arraysize("idlewakeups") * kCharWidth, -1, true, false, false },

-#endif // defined(OS_MACOSX) || defined(OS_LINUX)

#if defined(OS_LINUX)

{ IDS_TASK_MANAGER_OPEN_FD_COUNT_COLUMN, ui::TableColumn::RIGHT, -1, 0,