Add more unit tests for RequestPicker

components/offline_pages/background/offliner_policy.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_POLICY_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_POLICY_H_
 
 namespace {
 const int kMaxRetries = 2;
 const int kBackgroundTimeBudgetSeconds = 170;
 const int kSinglePageTimeBudgetSeconds = 120;
 const int kMinimumBatteryPercentageForNonUserRequestOfflining = 50;
 }  // namespace
 
 namespace offline_pages {
 
 // Policy for the Background Offlining system.  Some policy will belong to the
 // RequestCoordinator, some to the RequestQueue, and some to the Offliner.
 class OfflinerPolicy {
  public:
-  OfflinerPolicy(){};
+  OfflinerPolicy()
+      : prefer_untried_requests_(false),

[fgorski, 2016/07/25 16:22:57]

please put that into the .cc file.

[Pete Williamson, 2016/07/25 19:54:20]

There is no .cc file yet.  It will be coming in a later update, to help us get
values from Finch.  Is it OK to wait until then before creating the .cc file?

+        prefer_earlier_requests_(true),
+        retry_count_is_more_important_than_recency_(true) {}
+
+  OfflinerPolicy(bool prefer_untried, bool prefer_earlier,

[fgorski, 2016/07/25 16:22:57]

same here + git cl format.

[Pete Williamson, 2016/07/25 19:54:20]

Format done

+                 bool prefer_retry_count)
+      : prefer_untried_requests_(prefer_untried),
+        prefer_earlier_requests_(prefer_earlier),
+        retry_count_is_more_important_than_recency_(prefer_retry_count) {}
 
   // TODO(petewil): Numbers here are chosen arbitrarily, do the proper studies
   // to get good policy numbers.
 
   // TODO(petewil): Eventually this should get data from a finch experiment.
 
   // Returns true if we should prefer retrying lesser tried requests.
-  bool ShouldPreferUntriedRequests() { return false; }
+  bool ShouldPreferUntriedRequests() { return prefer_untried_requests_; }

[fgorski, 2016/07/25 16:22:57]

Can this method be marked const?
Same for the 2 that follow.

[Pete Williamson, 2016/07/25 19:54:21]

Done.

 
   // Returns true if we should prefer older requests of equal number of tries.
-  bool ShouldPreferEarlierRequests() { return true; }
+  bool ShouldPreferEarlierRequests() { return prefer_earlier_requests_; }
 
   // Returns true if retry count is considered more important than recency in
   // picking which request to try next.
-  bool RetryCountIsMoreImportantThanRecency() { return true; }
+  bool RetryCountIsMoreImportantThanRecency() {
+    return retry_count_is_more_important_than_recency_;
+  }
 
   // The max number of times we will retry a request.
   int GetMaxRetries() { return kMaxRetries; }
 
   // How many seconds to keep trying new pages for, before we give up,  and
   // return to the scheduler.
   int GetBackgroundProcessingTimeBudgetSeconds() {
     return kBackgroundTimeBudgetSeconds;
   }
 
   // How long do we allow a page to load before giving up on it
   int GetSinglePageTimeBudgetInSeconds() {
     return kSinglePageTimeBudgetSeconds;
   }
 
   // How much battery must we have before fetching a page not explicitly
   // requested by the user?
   int GetMinimumBatteryPercentageForNonUserRequestOfflining() {
     return kMinimumBatteryPercentageForNonUserRequestOfflining;
   }
+
+ private:
+  bool prefer_untried_requests_;
+  bool prefer_earlier_requests_;
+  bool retry_count_is_more_important_than_recency_;
 };
 }
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_POLICY_H_