Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 2178703002: Blink ImageCapture: adding OWNERS file (Closed)

Created:
4 years, 5 months ago by mcasas
Modified:
4 years, 5 months ago
Reviewers:
haraken, foolip
CC:
chromium-reviews, blink-reviews, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink ImageCapture: adding OWNERS file Adding specific OWNERS file for Source/modules/imagecapture (note that other potential Owners e.g. mlamouri@ are already in Source/modules etc.) Committed: https://crrev.com/8cafd0e7ee8f56fa659b9dd6707ac859309c37e5 Cr-Commit-Position: refs/heads/master@{#407321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A third_party/WebKit/Source/modules/imagecapture/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mcasas
4 years, 5 months ago (2016-07-22 23:19:19 UTC) #2
mcasas
foolip@ Owners RS plz.
4 years, 5 months ago (2016-07-22 23:19:35 UTC) #3
foolip
RS LGTM
4 years, 5 months ago (2016-07-22 23:35:58 UTC) #4
foolip
On 2016/07/22 23:35:58, foolip wrote: > RS LGTM I wouldn't put "WebKit" in the description ...
4 years, 5 months ago (2016-07-22 23:36:20 UTC) #5
mcasas
On 2016/07/22 23:36:20, foolip wrote: > On 2016/07/22 23:35:58, foolip wrote: > > RS LGTM ...
4 years, 5 months ago (2016-07-22 23:37:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178703002/1
4 years, 5 months ago (2016-07-22 23:37:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-23 00:48:12 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8cafd0e7ee8f56fa659b9dd6707ac859309c37e5 Cr-Commit-Position: refs/heads/master@{#407321}
4 years, 5 months ago (2016-07-23 00:49:39 UTC) #13
haraken
4 years, 5 months ago (2016-07-23 16:51:51 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698