Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2178693002: Revert "Add new atomic operations and use them in two places." (Closed)

Created:
4 years, 5 months ago by Florian Schneider
Modified:
4 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add new atomic operations and use them in two places." This reverts commit 27863288dbff2f008255a89854b73e2ab698c9f1. Cross ARM and Windows build failing. TBR=rmacnak@google.com, Committed: https://github.com/dart-lang/sdk/commit/8cd73fd94c226130595acc0c4c29e1b088127ffc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -73 lines) Patch
M runtime/vm/atomic.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/atomic_android.h View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/atomic_fuchsia.h View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/atomic_linux.h View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/atomic_macos.h View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/atomic_win.h View 1 chunk +0 lines, -12 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 5 months ago (2016-07-22 22:54:05 UTC) #3
Florian Schneider
Committed patchset #1 (id:1) manually as 8cd73fd94c226130595acc0c4c29e1b088127ffc (presubmit successful).
4 years, 5 months ago (2016-07-22 22:54:30 UTC) #5
rmacnak
4 years, 5 months ago (2016-07-22 23:22:37 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698