Have presubmit accept various Code-Review label configurations

Have presubmit accept various Code-Review label configurations

Since different projects can have different configurations for what
the maximum value of the "Code-Review" label is in Gerrit, this teaches
presubmit_support to inspect the maximum configured value and see who
has granted it (the same behavior as the Submit button in Gerrit itself).

R=andybons@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=630738
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/565adb55a6b560310c938ebacd4a9267958fdac4

[martiniss, 2016-07-22 21:41:17]

lgtm

https://codereview.chromium.org/2178673002/diff/1/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/2178673002/diff/1/presubmit_support.py#newcod...
presubmit_support.py:250: for r in
self.GetChangeInfo(issue)['labels']['Code-Review']['all']
Use cr here?

[agable, 2016-07-22 21:43:41]

Also added some tests.

https://codereview.chromium.org/2178673002/diff/1/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/2178673002/diff/1/presubmit_support.py#newcod...
presubmit_support.py:250: for r in
self.GetChangeInfo(issue)['labels']['Code-Review']['all']
On 2016/07/22 at 21:41:16, martiniss wrote:
> Use cr here?

Right, fixed.

[agable, 2016-07-22 21:45:10]

The CQ bit was checked by agable@chromium.org

[agable, 2016-07-22 21:45:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
martiniss@chromium.org
Link to the patchset: https://codereview.chromium.org/2178673002/#ps20001
(title: "Tests and comments")

[commit-bot: I haz the power, 2016-07-22 21:45:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 21:48:09]

Description was changed from

==========
Have presubmit accept various Code-Review label configurations

Since different projects can have different configurations for what
the maximum value of the "Code-Review" label is in Gerrit, this teaches
presubmit_support to inspect the maximum configured value and see who
has granted it (the same behavior as the Submit button in Gerrit itself).

R=andybons@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=630738
==========

to

==========
Have presubmit accept various Code-Review label configurations

Since different projects can have different configurations for what
the maximum value of the "Code-Review" label is in Gerrit, this teaches
presubmit_support to inspect the maximum configured value and see who
has granted it (the same behavior as the Submit button in Gerrit itself).

R=andybons@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=630738

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/565adb55a6b560...
==========

[commit-bot: I haz the power, 2016-07-22 21:48:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/565adb55a6b560...

[tandrii(chromium), 2016-07-25 09:26:55]

VERY LGTM because of tests.