Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2178643002: Converted Observatory isolate-ref element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Converted Observatory isolate-ref element #

Patch Set 3 : Added Uris helper function #

Patch Set 4 : Merged with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -18 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 4 chunks +5 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_ref.dart View 1 2 1 chunk +59 lines, -4 lines 0 comments Download
D runtime/observatory/lib/src/elements/isolate_ref.html View 1 1 chunk +0 lines, -9 lines 0 comments Download
A runtime/observatory/lib/src/elements/isolate_ref_wrapper.dart View 1 chunk +78 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_summary.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-22 19:55:42 UTC) #2
Cutch
LGTM w/c https://codereview.chromium.org/2178643002/diff/1/runtime/observatory/lib/src/elements/isolate_ref.dart File runtime/observatory/lib/src/elements/isolate_ref.dart (right): https://codereview.chromium.org/2178643002/diff/1/runtime/observatory/lib/src/elements/isolate_ref.dart#newcode63 runtime/observatory/lib/src/elements/isolate_ref.dart:63: '#/inspect?isolateId=${Uri.encodeComponent(isolate.id)}') switch to using the uri helpers
4 years, 5 months ago (2016-07-22 20:08:32 UTC) #3
cbernaschina
4 years, 5 months ago (2016-07-24 23:31:54 UTC) #4
cbernaschina
4 years, 5 months ago (2016-07-25 00:09:33 UTC) #5
cbernaschina
https://codereview.chromium.org/2178643002/diff/1/runtime/observatory/lib/src/elements/isolate_ref.dart File runtime/observatory/lib/src/elements/isolate_ref.dart (right): https://codereview.chromium.org/2178643002/diff/1/runtime/observatory/lib/src/elements/isolate_ref.dart#newcode63 runtime/observatory/lib/src/elements/isolate_ref.dart:63: '#/inspect?isolateId=${Uri.encodeComponent(isolate.id)}') On 2016/07/22 20:08:31, Cutch wrote: > switch to ...
4 years, 5 months ago (2016-07-25 00:19:13 UTC) #6
rmacnak
lgtm
4 years, 5 months ago (2016-07-25 16:45:21 UTC) #7
cbernaschina
4 years, 5 months ago (2016-07-25 17:00:18 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
c6d346d692cb15e8b07c914ea163d3a59348d959 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698