Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2178623002: fix text rotation for skia (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 4 months ago
Reviewers:
dsinclair, reed1
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

fix text rotation for skia My initial guess for text rotation worked for scaled but not skewed or rotated. R=dsinclair@chromium.org,reed@google.com Committed: https://pdfium.googlesource.com/pdfium/+/3e805789a3855007018f8463797a4f9fdb19838d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
caryclark
4 years, 5 months ago (2016-07-22 19:44:15 UTC) #1
caryclark
oops, misspelled Dan's email :(
4 years, 4 months ago (2016-07-25 16:12:44 UTC) #4
reed1
lgtm
4 years, 4 months ago (2016-07-25 16:49:59 UTC) #5
dsinclair
lgtm
4 years, 4 months ago (2016-07-25 18:06:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178623002/1
4 years, 4 months ago (2016-07-25 18:06:23 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 18:28:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3e805789a3855007018f8463797a4f9fdb19...

Powered by Google App Engine
This is Rietveld 408576698